Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools] Visual Studio 2017 (15.2) required #5

Closed
wants to merge 1 commit into from
Closed

[tools] Visual Studio 2017 (15.2) required #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions design/###-tools-visualstudio.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@

# Proposal: Tools - Visual Studio 2017 (15.2) required

| **Status** | **Proposed/Accepted/Deprecated** |
|:------------------|:---------------------------------------------|
| **RFC #** | #### |
| **Submitted** | YYYY-MM-DD |
| **Dependencies** | RFC #, # |

---

## Summary
Declare **Microsoft Visual Studio 2017 (15.2)** as the minimal version supported.


## Motivation
Visual Studio 2017 (15.2) was [released on May 2017](https://docs.microsoft.com/visualstudio/releasenotes/vs2017-relnotes-v15.2). This version allows to install
side-by-side different versions of the MSVC toolset, it allows you to [build binaries
that are fully compatible with the ones built using older versions](https://devblogs.microsoft.com/cppblog/stuck-on-an-older-toolset-version-move-to-visual-studio-2015-without-upgrading-your-toolset/).

Visual Studio 2017 (15.2) includes [`wswhere` application](https://github.com/microsoft/vswhere).
Copy link

@a4z a4z Nov 12, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to fix that typo here, wswhere -> vswhere
but the repo jgsogo:proposal does not exist (for me) , so I do not know how or where to submit the pr for the pr :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the repository should be public

This tool is needed Conan to locate Visual Studio installation and toolsets available (link to proposal required).


## Proposal
Declare **Visual Studio 2017 (15.2)** as the minimal version supported.


## Alternative Approaches
Conan migth need Visual Studio 2017 (15.2) **installed**, but it can target older
jgsogo marked this conversation as resolved.
Show resolved Hide resolved
versions (`vswhere` is able to find older installations too).


## Detailed Design


## Open issues
* Evidence of CLI changes (calling MSBuild or other tools), format changes
in the `.props` files or the data available to them (used in Conan generators
and toolchains). Besides locating the installation, is there any reason not to
support older versions?

* MSBuild doesn't support long paths until version 16.0 ([link](https://github.com/dotnet/msbuild/issues/53#issuecomment-459062618)).


## Future Extensions