Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conan runner docs added #3699

Merged
merged 31 commits into from
May 6, 2024
Merged

conan runner docs added #3699

merged 31 commits into from
May 6, 2024

Conversation

davidsanfal
Copy link
Contributor

@davidsanfal davidsanfal commented Apr 29, 2024 •
edited by AbrilRBS
Loading

@CLAassistant
Copy link

CLAassistant commented Apr 29, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@davidsanfal davidsanfal added this to the 2.3.0 milestone Apr 30, 2024
@davidsanfal davidsanfal marked this pull request as ready for review April 30, 2024 13:03
AbrilRBS
AbrilRBS reviewed May 4, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. These are just mostly wording suggestions, but I have a few comments in some sections too :)

reference/runners.rst Outdated Show resolved Hide resolved
reference/runners.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
@AbrilRBS AbrilRBS mentioned this pull request May 6, 2024
Merged
5 tasks
czoido
czoido reviewed May 6, 2024
View reviewed changes
reference/runners/docker.rst Outdated Show resolved Hide resolved
czoido
czoido reviewed May 6, 2024
View reviewed changes
reference/runners/docker.rst Outdated Show resolved Hide resolved
czoido
czoido reviewed May 6, 2024
View reviewed changes
reference/runners/docker.rst Outdated Show resolved Hide resolved
czoido
czoido reviewed May 6, 2024
View reviewed changes
reference/runners/docker.rst Outdated Show resolved Hide resolved
czoido
czoido reviewed May 6, 2024
View reviewed changes
reference/runners/docker.rst Outdated Show resolved Hide resolved
czoido
czoido reviewed May 6, 2024
View reviewed changes
reference/runners/docker.rst Outdated Show resolved Hide resolved
czoido
czoido reviewed May 6, 2024
View reviewed changes
reference/runners/docker.rst Outdated Show resolved Hide resolved
czoido
czoido reviewed May 6, 2024
View reviewed changes
reference/runners/docker.rst Outdated Show resolved Hide resolved
czoido
czoido reviewed May 6, 2024
View reviewed changes
reference/runners/docker.rst Outdated Show resolved Hide resolved
czoido
czoido reviewed May 6, 2024
View reviewed changes
reference/runners/docker.rst Outdated Show resolved Hide resolved
davidsanfal and others added 10 commits May 6, 2024 16:36
@davidsanfal @AbrilRBS
Update reference/runners.rst
3b6a0ce 
Co-authored-by: Rubén Rincón Blanco <[email protected]>
@davidsanfal @AbrilRBS
Update reference/runners.rst
52afd3a 
Co-authored-by: Rubén Rincón Blanco <[email protected]>
@davidsanfal @AbrilRBS
Update reference/runners/docker.rst
493133b 
Co-authored-by: Rubén Rincón Blanco <[email protected]>
@davidsanfal @AbrilRBS
Update reference/runners/docker.rst
cf7e0d0 
Co-authored-by: Rubén Rincón Blanco <[email protected]>
@davidsanfal @AbrilRBS
Update reference/runners/docker.rst
a8af193 
Co-authored-by: Rubén Rincón Blanco <[email protected]>
@davidsanfal @AbrilRBS
Update reference/runners/docker.rst
1a0f762 
Co-authored-by: Rubén Rincón Blanco <[email protected]>
@davidsanfal @AbrilRBS
Update reference/runners/docker.rst
51e4a1a 
Co-authored-by: Rubén Rincón Blanco <[email protected]>
@davidsanfal @AbrilRBS
Update reference/runners/docker.rst
eb22c6a 
Co-authored-by: Rubén Rincón Blanco <[email protected]>
@davidsanfal @AbrilRBS
Update reference/runners/docker.rst
b6c2387 
Co-authored-by: Rubén Rincón Blanco <[email protected]>
@davidsanfal @AbrilRBS
Update reference/runners/docker.rst
6b27ee6 
Co-authored-by: Rubén Rincón Blanco <[email protected]>
davidsanfal and others added 8 commits May 6, 2024 16:38
czoido
czoido reviewed May 6, 2024
View reviewed changes
reference/runners.rst Outdated Show resolved Hide resolved
davidsanfal and others added 8 commits May 6, 2024 17:23
@davidsanfal @AbrilRBS
Update reference/runners.rst
da32acb 
Co-authored-by: Rubén Rincón Blanco <[email protected]>
@davidsanfal @AbrilRBS
Update reference/runners/docker.rst
c9fb326 
Co-authored-by: Rubén Rincón Blanco <[email protected]>
@davidsanfal @AbrilRBS
Update reference/runners/docker.rst
453ae1b 
Co-authored-by: Rubén Rincón Blanco <[email protected]>
@davidsanfal @AbrilRBS
Update reference/runners/docker.rst
03ce453 
Co-authored-by: Rubén Rincón Blanco <[email protected]>
@davidsanfal @AbrilRBS
Update reference/runners/docker.rst
ff3b5f4 
Co-authored-by: Rubén Rincón Blanco <[email protected]>
@davidsanfal @AbrilRBS
Update reference/runners/docker.rst
e604cf8 
Co-authored-by: Rubén Rincón Blanco <[email protected]>
@davidsanfal @AbrilRBS
Update reference/runners/docker.rst
7036998 
Co-authored-by: Rubén Rincón Blanco <[email protected]>
@davidsanfal
note about package id added
05235e0
@czoido czoido self-assigned this May 6, 2024
@czoido czoido merged commit 313343b into conan-io:develop2 May 6, 2024
2 checks passed
franramirez688 pushed a commit to Neeeflix/conan-docs that referenced this pull request Jun 4, 2024
@davidsanfal @AbrilRBS
@czoido @franramirez688
conan runner docs added (conan-io#3699)
5114129 
* conan runner docs added

* Update reference/runners.rst

Co-authored-by: Rubén Rincón Blanco <[email protected]>

* Update reference/runners.rst

Co-authored-by: Rubén Rincón Blanco <[email protected]>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <[email protected]>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <[email protected]>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <[email protected]>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <[email protected]>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <[email protected]>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <[email protected]>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <[email protected]>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <[email protected]>

* Update reference/runners/docker.rst

Co-authored-by: Carlos Zoido <[email protected]>

* Update reference/runners/docker.rst

Co-authored-by: Carlos Zoido <[email protected]>

* Update reference/runners/docker.rst

Co-authored-by: Carlos Zoido <[email protected]>

* Update reference/runners/docker.rst

Co-authored-by: Carlos Zoido <[email protected]>

* Update reference/runners/docker.rst

Co-authored-by: Carlos Zoido <[email protected]>

* Update reference/runners/docker.rst

Co-authored-by: Carlos Zoido <[email protected]>

* Update reference/runners/docker.rst

Co-authored-by: Carlos Zoido <[email protected]>

* Update reference/runners/docker.rst

Co-authored-by: Carlos Zoido <[email protected]>

* docker runners examples added

* basic docker runner example updated

* Update reference/runners.rst

Co-authored-by: Rubén Rincón Blanco <[email protected]>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <[email protected]>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <[email protected]>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <[email protected]>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <[email protected]>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <[email protected]>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <[email protected]>

* note about package id added

* Update examples/runners/docker/basic.rst

Co-authored-by: Carlos Zoido <[email protected]>

* conan docker runner basic example updated

---------

Co-authored-by: Rubén Rincón Blanco <[email protected]>
Co-authored-by: Carlos Zoido <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS left review comments

@czoido czoido czoido approved these changes

@jcar87 jcar87 Awaiting requested review from jcar87

Assignees

@czoido czoido

Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@davidsanfal @CLAassistant @czoido @AbrilRBS