add CMAKE_GENERATOR_PLATFORM and CMAKE_GENERATOR_TOOLSET conditionall… #8333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y to Visual Studio only in CMakeToolchain
|
It seems this is not necessary. The toolchain already incorporated checks, if the generator is not "Visual" one, it will not add any longer those variables. This can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y to Visual Studio only in CMakeToolchain
Changelog: Fix: Do not define CMAKE_GENERATOR_PLATFORM and CMAKE_GENERATOR_TOOLSET in the
CMakeToolchainfile unless the CMake generator is "Visual Studio". Fix #7485Docs: Omit
This might be a temporary measure, as the generator needs to become more explicit at some point (via configuration or some other way), so the
CMakeToolchainmight decide to completely skip those definitions if they don't apply.