Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix per-package settings exact match for packages without user/channel #8281

Merged
merged 2 commits into from
Jan 11, 2021
Merged

fix per-package settings exact match for packages without user/channel #8281

merged 2 commits into from
Jan 11, 2021

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Jan 4, 2021 •
edited by czoido
Loading

Changelog: BugFix: Fix per-package settings exact match for packages without user/channel.
Docs: Omit

Could this be breaking in some way? Please review.

@memsharded memsharded requested a review from jgsogo January 4, 2021 14:26
@memsharded memsharded mentioned this pull request Jan 4, 2021
Merged
@memsharded memsharded added this to the 1.33 milestone Jan 4, 2021
jgsogo
jgsogo approved these changes Jan 8, 2021
View reviewed changes
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, given how it works now, we need this extra exact match.

Thinking about Conan v2.0, IMO, we should use here only the name of the package. Is there a use-case where you want to modify something (in the profile) only for a certain version?

@memsharded memsharded merged commit 02366ef into conan-io:develop Jan 11, 2021
@memsharded memsharded deleted the fix/package_settings branch January 11, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czoido czoido czoido approved these changes

@jgsogo jgsogo jgsogo approved these changes

Assignees

@czoido czoido

Labels
type: look into
Projects
None yet
Milestone
1.33
Development

Successfully merging this pull request may close these issues.
3 participants
@memsharded @jgsogo @czoido