Feature/msvc #8201

memsharded · 2020-12-12T22:04:58Z

Changelog: Feature: Add new msvc compiler setting and preliminary support in conan.tools.cmake generator and toolchain.
Docs: conan-io/docs#1991

Close #3573

It is providing a compatible_packages approach to compatibility with Visual Studio compiler.

Support in conan.tools.microsoft following in a different PR
Support for intel compiler will follow in a different PR, lets first do the very basics.
Auto-detect for profile should probably be delayed until it is way more stable, not being tackled now.
Definition of the VS IDE version to use for a given compiler version (when not the default) will require improving the "configuration" of the toolchains, that will be done in other PRs, at the moment only the default compiler-version <=> VS IDE version is supported

danimtb · 2020-12-14T16:27:28Z

If it is possible I would add the compatibility by default to the Visual Studio compiler if we want to encourage users to move to this msvc compiler. In ConanCenter we can generate new configurations now, but generating all visual studio packages twice will be too much IMO. Probably we will need to do the compiler switch in Conan 2.0

SSE4 · 2020-12-14T21:47:12Z

is it possible to use a trick similar to Intel's base_compatible?

danimtb · 2020-12-15T08:55:21Z

yes, something similar to that in package ID but it should be applied by default in conan 1.X IMO

SSE4 · 2020-12-15T09:53:20Z

to clarify, are we proposing one-way (one-directional) compatibility layer?
e.g. the following profile:

compiler = Visual Studio
compiler.version = 15

will be able to use packages from:

compiler = msvc
compiler.version = 1928

but not vice versa

SSE4 · 2020-12-28T16:03:43Z

conans/model/info.py

+            return
+
+        compatible = self.clone()
+        version = compatible.settings.compiler.version


Suggested change

version = compatible.settings.compiler.version

version = compatible.settings.get_safe("compiler.version")

SSE4 · 2020-12-28T16:04:01Z

conans/model/info.py

+
+        compatible = self.clone()
+        version = compatible.settings.compiler.version
+        runtime = compatible.settings.compiler.runtime


Suggested change

runtime = compatible.settings.compiler.runtime

runtime = compatible.settings.get_safe("compiler.runtime")

Nop, at this point, using the msvc compiler, the compiler.runtime must be defined, otherwise I want it to raise, not to continue silently. Why would you want/allow this to be undefined here? It is not possible in the settings (it doesn't have a None value)

that's very possible settings.yml might be modified by the user, either manually, or by running conan config install. user may add None value or remove compiler.runtime sub-setting completely. IMO code should be reliable for custom settings, as we're allowing them and promote it as a first-class feature (especially for Enterprise users).

So far this would be an unsupported case, the msvc compiler always has a runtime, it is not possible to compile without it. What does a None value means? What is the use case? It is important to code new features initially more restrictive/limited scope, and learn from use cases, better than be relaxed, allow use cases that we completely ignore and that might have other implications. I strongly prefer to evolve from the basic "canonical" use case, and account for variants and special use cases later.

SSE4 · 2020-12-28T16:04:15Z

conans/model/info.py

+        compatible = self.clone()
+        version = compatible.settings.compiler.version
+        runtime = compatible.settings.compiler.runtime
+        runtime_type = compatible.settings.compiler.runtime_type


Suggested change

runtime_type = compatible.settings.compiler.runtime_type

runtime_type = compatible.settings.get_safe("compiler.runtime_type")

SSE4 · 2020-12-28T16:04:57Z

conans/model/info.py

+        _visuals = {'19.0': '14',
+                    '19.1': '15',
+                    '19.2': '16'}
+        compatible.settings.compiler.version = _visuals[version]


may raise, need a sanity check (maybe deserves a test)

Sure, this is a preliminary implementation, this needs to be improved.

SSE4 · 2020-12-28T16:05:08Z

conans/model/info.py

+        runtime_type = compatible.settings.compiler.runtime_type
+
+        compatible.settings.compiler = "Visual Studio"
+        version = str(version)[:4]


may raise, need a sanity check (maybe deserves a test)

SSE4 · 2020-12-28T16:09:43Z

conan/tools/cmake/utils.py

@@ -48,6 +48,15 @@ def get_generator(conanfile):

    compiler = conanfile.settings.get_safe("compiler")
    compiler_version = conanfile.settings.get_safe("compiler.version")
+
+    if compiler == "msvc":
+        version = compiler_version[:4]  # Remove the latest version number 19.1X if existing


this line (and the line below) may raise, need sanity checks (and maybe tests)

conans/client/conf/__init__.py

jgsogo · 2021-01-14T11:36:32Z

conans/client/settings_preprocessor.py

@@ -15,6 +15,14 @@ def _check_cppstd(settings):
    cppstd = settings.get_safe("cppstd")
    compiler_cppstd = settings.get_safe("compiler.cppstd")

+    if compiler == "msvc":
+        # This is hardcoded at the moment, because the minimum defined version is 19.0, with c++14
+        # TODO: When older versions of msvc are defined in settings, cppstd can be None


Suggested change

# TODO: When older versions of msvc are defined in settings, cppstd can be None

# TODO: Decide if we want to force the user to provide the 'cppstd' value always

I have better removed the None value in settings leaving: cppstd: [14, 17, 20]. Not defining it will raise an error. Current design was especulative, assuming older VS versions. For the current versions cppstd: [14, 17, 20] is the correct definition, lets wait to handed this in the settings_preprocessor until we really have the problem because defining older versions.

In that case we might want to add something like cppstd: [undefined, 14, 17, 20] instead of None, in this way, it is still explicit and doesn't allow not defining it. The internal helpers like cppstd_flag should account for this, but this can wait.

1929->19.29

1929->19.29 protobuf:shared=True compiler.cppstd=14

1929->19.29 protobuf:shared=True compiler.cppstd=14 MT

1929->19.29 protobuf:shared=True compiler.cppstd=14 MT 14cppstd

[no ci] conan-io/conan#8201 conan-io/conan#3311 1929->19.29 protobuf:shared=True compiler.cppstd=14 MT 14cppstd [no ci] conan profile compiler=msvc

memsharded added 3 commits December 10, 2020 23:29

working in msvc new settings

0a6f828

merged develop

27c6fc4

preliminary support for msvc compiler

72f6bee

memsharded marked this pull request as draft December 12, 2020 22:05

memsharded mentioned this pull request Dec 12, 2020

Incorrect handling of MSVC versions #3573

Closed

fix migration

369143b

memsharded requested review from jgsogo and danimtb December 14, 2020 09:06

memsharded mentioned this pull request Dec 14, 2020

[bug] 'Visual Studio' settings are incorrect. #7019

Closed

memsharded added 15 commits December 15, 2020 13:49

changing to version 19.1, 19.11, etc

fb110ba

merged develop

ee99a73

working on static/dynamic runtime

cfc28fe

Merge branch 'develop' into feature/msvc

c55072f

extracting toolchain checkers to use in CMake

b245c43

removed unused import

c363312

adding checks

fb6b57b

adding check

e98d911

Merge branch 'feature/toolchain_checkers' into feature/msvc

ae91af5

first proposal

3c3a7b3

msvc proposal for runtime

3bb3e4d

fix migration test

ef36fd2

fixing tests

2000c85

binary compatibility

640b134

merged develop

fca3c79

memsharded requested review from czoido and lasote December 17, 2020 16:56

SSE4 reviewed Dec 28, 2020

View reviewed changes

review

315de05

memsharded mentioned this pull request Jan 7, 2021

Multiple compilers supporting the same ABI on Windows ( MVSC, icl (Intel) and clang-cl) #8291

Closed

memsharded added 6 commits January 7, 2021 22:06

Merge branch 'develop' into feature/msvc

0c7935f

Merge branch 'develop' into feature/msvc

9bdeca1

protection

72adaf3

merged develop

8cce2e1

adding msvc cppstd flag

b252e83

fix migration test

637a9e7

memsharded marked this pull request as ready for review January 13, 2021 19:51

memsharded added 2 commits January 14, 2021 02:16

Merge branch 'develop' into feature/msvc

3983c43

requiring compiler.cppstd to be defined

2738424

jgsogo approved these changes Jan 14, 2021

View reviewed changes

removing cppstd=None

47c339b

memsharded merged commit 00c7cc2 into conan-io:develop Jan 14, 2021

memsharded deleted the feature/msvc branch January 14, 2021 16:12

dependabot bot mentioned this pull request Mar 11, 2021

Bump conan from 1.27.0 to 1.34.1 librevault/librevault#185

Closed

ChristophStrehle mentioned this pull request Mar 12, 2021

[bug] msvc tries to build with Unix Makefiles #8637

Closed

liu-kan added a commit to liu-kan/gSMFRETda that referenced this pull request Nov 23, 2021

[no ci] conan-io/conan#8201 conan-io/conan#3311

3967542

liu-kan added a commit to liu-kan/gSMFRETda that referenced this pull request Nov 23, 2021

[no ci] conan-io/conan#8201 conan-io/conan#3311

22906f0

1929->19.29

liu-kan added a commit to liu-kan/gSMFRETda that referenced this pull request Nov 23, 2021

[no ci] conan-io/conan#8201 conan-io/conan#3311

58f1328

1929->19.29 protobuf:shared=True compiler.cppstd=14

liu-kan added a commit to liu-kan/gSMFRETda that referenced this pull request Nov 23, 2021

[no ci] conan-io/conan#8201 conan-io/conan#3311

92902bb

1929->19.29 protobuf:shared=True compiler.cppstd=14 MT

liu-kan added a commit to liu-kan/gSMFRETda that referenced this pull request Nov 23, 2021

[no ci] conan-io/conan#8201 conan-io/conan#3311

e54062c

1929->19.29 protobuf:shared=True compiler.cppstd=14 MT 14cppstd

liu-kan added a commit to liu-kan/gSMFRETda that referenced this pull request Nov 24, 2021

[no ci] actions/cache@v2 restore-keys

b8dc828

[no ci] conan-io/conan#8201 conan-io/conan#3311 1929->19.29 protobuf:shared=True compiler.cppstd=14 MT 14cppstd [no ci] conan profile compiler=msvc

SpaceIm mentioned this pull request Jan 2, 2022

[question] Should CCI recipes begin to support the "new" msvc compiler in settings? conan-io/conan-center-index#6155

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/msvc #8201

Feature/msvc #8201

memsharded commented Dec 12, 2020 •

edited

Loading

danimtb commented Dec 14, 2020

SSE4 commented Dec 14, 2020

danimtb commented Dec 15, 2020

SSE4 commented Dec 15, 2020

SSE4 Dec 28, 2020

SSE4 Dec 28, 2020

memsharded Dec 28, 2020

SSE4 Dec 29, 2020

memsharded Dec 29, 2020

SSE4 Dec 28, 2020

SSE4 Dec 28, 2020 •

edited

Loading

memsharded Dec 28, 2020

SSE4 Dec 28, 2020 •

edited

Loading

SSE4 Dec 28, 2020

jgsogo Jan 14, 2021

memsharded Jan 14, 2021

	version = compatible.settings.compiler.version
	version = compatible.settings.get_safe("compiler.version")

	runtime = compatible.settings.compiler.runtime
	runtime = compatible.settings.get_safe("compiler.runtime")

	runtime_type = compatible.settings.compiler.runtime_type
	runtime_type = compatible.settings.get_safe("compiler.runtime_type")

	# TODO: When older versions of msvc are defined in settings, cppstd can be None
	# TODO: Decide if we want to force the user to provide the 'cppstd' value always

Feature/msvc #8201

Feature/msvc #8201

Conversation

memsharded commented Dec 12, 2020 • edited Loading

danimtb commented Dec 14, 2020

SSE4 commented Dec 14, 2020

danimtb commented Dec 15, 2020

SSE4 commented Dec 15, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SSE4 Dec 28, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SSE4 Dec 28, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

memsharded commented Dec 12, 2020 •

edited

Loading

SSE4 Dec 28, 2020 •

edited

Loading

SSE4 Dec 28, 2020 •

edited

Loading