-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: meson toolchain #7662
Feature: meson toolchain #7662
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking very good, a great good first step to start improving Meson integration via toolchains.
@memsharded thanks, the bad thing is probably it will be blocked until meson 0.56 release as most of things in native/cross files right now don't work according to the documentation - values specified in toolchain are simply ignored... |
9705215
to
c8a6f52
Compare
Uhm... I guess that we should wait, yes, and plan for the future of Meson, not the current state, because it is still not stable 0.X release. Is there an estimated date for 0.56? It would be great to know how fast the community is upgrading to newer Meson versions too. |
asked at mesonbuild/meson#7699 (comment) about ETA for 0.56 |
c8a6f52
to
ab992c6
Compare
update: meson 0.56rc1 is out, and I expect release in several days, so I am going back to refresh this PR |
updated, works locally with meson 0.56rc2. please review. |
@jgsogo @memsharded how can I ensure the right meson is installed on CI?
locally, seems to be working with |
eb2d05d
to
3a6df52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good job. Check the comments, and lets have this merged in Conan 1.32
Signed-off-by: SSE4 <[email protected]>
3a6df52
to
938ea75
Compare
|
||
try: | ||
from collections.abc import Iterable | ||
except ImportError: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this was not strictly necessary, as Meson only works with Py3, but not necessary to change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meson yes, but conan works with 2.x and 3.x, and they may use different interpreters (e.g. conan might use pyinstaller's one)
Signed-off-by: SSE4 <[email protected]>
4103a66
to
34830bb
Compare
Signed-off-by: SSE4 <[email protected]>
Merged! Note that in #8096, it will be moved to the new |
related: #7155 #7075
/cc @TheQwertiest @KristianJerpetjon @kristofferkoch
this is an early WIP - mostly to discuss the interface and implementation details.
unfortunately I cannot get even basic things of
meson native file
to work according to the documentation - meson appears to ignore project-specific options and built-in options specified in the native file.meson issues: mesonbuild/meson#7697 mesonbuild/meson#7699
as things above didn't work for me, there are not many things tested yet.
open questions:
libdir
,bindir
and so on)?custom
/specify nothing)Changelog: Feature: meson toolchain
Docs: conan-io/docs#1943
develop
branch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.