Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: fix iOS CMake architecture #7157

Closed
wants to merge 2 commits into from

Conversation

SSE4
Copy link
Contributor

@SSE4 SSE4 commented Jun 6, 2020

closes: #7156

Changelog: Bugfix: fix iOS CMake architecture
Docs: omit

need to set CMAKE_OSX_ARCHITECTURES and CMAKE_OSX_SYSROOT

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@SSE4 SSE4 force-pushed the fix_ios_cmake_arch branch from 8f1ba1f to d30579e Compare June 6, 2020 11:34
@memsharded
Copy link
Member

This is broken (the test related to Migrations was broken in develop, but should be fixed now). Please fix it when possible. If we are doing a minor for 1.26, maybe we can submit this fix to it.

@SSE4 SSE4 force-pushed the fix_ios_cmake_arch branch from d30579e to 8f31243 Compare June 8, 2020 05:30
@SSE4 SSE4 changed the base branch from develop to release/1.26 June 8, 2020 15:40
@SSE4 SSE4 changed the base branch from release/1.26 to develop June 8, 2020 15:40
memsharded pushed a commit that referenced this pull request Jun 9, 2020
* - fix iOS CMake architecture

Signed-off-by: SSE4 <[email protected]>

* Update cmake_flags.py
@memsharded
Copy link
Member

This can be closed, will be merged to develop when 1.26 is released.

@memsharded memsharded closed this Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] incorrect architecture for iOS (CMake)
2 participants