Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: detect_windows_subsystem recognizes WSL #4347

Merged
merged 2 commits into from
Feb 26, 2019
Merged

Feature: detect_windows_subsystem recognizes WSL #4347

merged 2 commits into from
Feb 26, 2019

Conversation

SSE4
Copy link
Contributor

@SSE4 SSE4 commented Jan 21, 2019 •
edited by lasote
Loading

Changelog: Bugfix: tool.detect_windows_subsystem know recognizes WSL correctly.
Docs: omit

related to the #2817

detection based on suggestion from MSFT developer: microsoft/WSL#844

sse4@DESKTOP-E3NFU1V:~$ cat /proc/version
Linux version 4.4.0-43-Microsoft ([email protected]) (gcc version 5.4.0 (GCC) ) #1-Microsoft Wed Dec 31 14:42:53 PST 2014
sse4@DESKTOP-E3NFU1V:~$ cat /proc/sys/kernel/osrelease
4.4.0-43-Microsoft

/cc @db4

@ghost ghost assigned SSE4 Jan 21, 2019
@ghost ghost added the stage: review label Jan 21, 2019
@lasote lasote added this to the 1.13 milestone Feb 5, 2019
@jgsogo jgsogo requested a review from lasote February 20, 2019 12:36
@lasote lasote merged commit 304c00a into conan-io:develop Feb 26, 2019
@ghost ghost removed the stage: review label Feb 26, 2019
@jgsogo jgsogo mentioned this pull request Feb 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgsogo jgsogo jgsogo approved these changes

@lasote lasote Awaiting requested review from lasote

Assignees

@SSE4 SSE4

Labels
None yet
Projects
None yet
Milestone
1.13
Development

Successfully merging this pull request may close these issues.
3 participants
@SSE4 @jgsogo @lasote