Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed conan graph info --build=pkg download of sources #16349

Merged
merged 2 commits into from
May 28, 2024
Merged

Fixed conan graph info --build=pkg download of sources #16349

merged 2 commits into from
May 28, 2024

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented May 28, 2024 •
edited by czoido
Loading

Changelog: Bugfix: conan graph info .. --build=pkg doesn't download pkg sources unless tools.build:download_source is defined.
Docs: Omit

@memsharded memsharded added this to the 2.4.0 milestone May 28, 2024
@memsharded memsharded requested a review from danimtb May 28, 2024 12:34
@AbrilRBS
Copy link
Member

Good job @danimtb catching this one <3

danimtb
danimtb approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@danimtb danimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix! 👍

@memsharded memsharded merged commit 76fca6d into conan-io:develop2 May 28, 2024
2 checks passed
@memsharded memsharded deleted the fix/graph_info_sources branch May 28, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danimtb danimtb danimtb approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@memsharded @AbrilRBS @danimtb