Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow self.cpp_info access in validate_build() method #16135

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Disallow self.cpp_info access in validate_build() method #16135

merged 1 commit into from
Apr 29, 2024

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Apr 23, 2024 •
edited by czoido
Loading

Changelog: Bugfix: Disallow self.cpp_info access in validate_build() method.
Docs: Omit

Ensures symmetry with validate() method

@AbrilRBS AbrilRBS added this to the 2.3.0 milestone Apr 23, 2024
memsharded
memsharded approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but why? Did it happen in ConanCenter? What was the usage? Is there a high risk of breaking users that might be abusing this, but still it will be painful and we want to warn first?

@memsharded memsharded merged commit d818b6e into conan-io:develop2 Apr 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AbrilRBS @memsharded