-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMakeToolchain] Adding Xcode flags #10985
[CMakeToolchain] Adding Xcode flags #10985
Conversation
Basically, what I'm trying to do is to add some capabilities from the https://github.com/leetal/ios-cmake repository so we'll be able to add some common Xcode flags if those configurations are enabled/disabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to check the toolchain you used as a reference to understand a little bit but at first sight, this looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look at the comments
a4163a6
to
82f9dc5
Compare
Hi @franramirez688 , I had a look at the ios-cmake repo and there it is set for both CMAKE_C_FLAGS and CMAKE_CXX_FLAGS (see https://github.com/leetal/ios-cmake/blob/master/ios.toolchain.cmake). |
That's a very good question. It looks like a bug indeed 🤔 I don't remember why but it looks like it was missed... |
Changelog: Feature: Added new configuration fields:
tools.apple:enable_bitcode
,tools.apple:enable_arc
andtools.apple:enable_visibility
.Changelog: Feature: Added new mechanism to inject common Xcode flags in
CMakeToolchain
generator if enabled Bitcode, ARC, or Visibility configurations.Closes: #9448
Docs: conan-io/docs#2506