libmysqlclient: fix few issues with all shared + fix FreeBSD + modernize #9350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
SpaceIm
force-pushed
the
libmysqlclient-modernize
branch
from
63ccfb2
to
599a700
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
SpaceIm
force-pushed
the
libmysqlclient-modernize
branch
from
98e3f31
to
404b964
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This was referenced Mar 7, 2022
|
I detected other pull requests that are modifying libmysqlclient/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
SSE4
previously approved these changes
Mar 7, 2022
ghost
mentioned this pull request
ericLemanissier
suggested changes
Mar 8, 2022
There was a problem hiding this comment.
This solves this error: https://github.com/ericLemanissier/conan-center-index/runs/5462356927?check_suite_focus=true#step:3:18002
/root/.conan/data/libmysqlclient/8.0.25/_/_/build/8a8358db748f21fb263fbe9fd5d357ca61d3e9c0/source_subfolder/mysys/stacktrace.cc:72:10: fatal error: 'libunwind.h' file not found
#include <libunwind.h>
cf:
- https://github.com/mysql/mysql-server/blob/8.0/configure.cmake#L84
- https://github.com/mysql/mysql-server/blob/8.0/mysys/stacktrace.cc#L73
Can you put "FreeBSD" in the PR description, so that it is built on my fork ? (like https://github.com/ericLemanissier/conan-center-index/runs/5462555278?check_suite_focus=true#step:3:20107)
SpaceIm
commented
Mar 8, 2022
Co-authored-by: ericLemanissier <[email protected]>
SpaceIm
changed the title
ericLemanissier
approved these changes
Mar 8, 2022
uilianries
approved these changes
Mar 8, 2022
SSE4
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tools.run_environment()is not sufficient due to SIP): simply rely on rpath injection by CMake in build treecloses #5670
conan-center hook activated.