-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boost: Fix path finder for python libraries #9059
boost: Fix path finder for python libraries #9059
Conversation
I detected other pull requests that are modifying boost/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
/cc @grafikrobot I don't remember all the details of how boost.python finds python libraries, it will require checking the docs and code, I only recall it was very cryptic, and AFAIK it requires a full path to the python library (otherwise, how did it know which one to pick if there are several variants in the same directory, like debug/release or static/shared). |
I recall a few PRs from @madebr trying to sort this out as well... there's too many issues and PRs I wasnt able to find anything 😖 |
That function is used here conan-center-index/recipes/boost/all/conanfile.py Lines 1188 to 1194 in 89e6169
I think that function is misnamed, it should be called _python_library_dirs or something similar.
|
reading https://github.com/boostorg/build/blob/ae1b579606d06b8d8900fe65fd63dffb46647588/src/tools/python.jam, it seems like it is indeed a library directory, not a path to the library file. @grafikrobot can you confirm? |
All green in build 2 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's move forward. If I have some time, I'll run some tests with python on different platforms, but no promises.
Specify library name and version: boost/all
Fixes #2973
conan-center hook activated.