Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost: ostracize boost_system #7482

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

madebr
Copy link
Contributor

@madebr madebr commented Oct 1, 2021

Specify library name and version: boost/all

In #7290, we declared boost_system as a header-only library.
However, other libraries still link to a dummy static/shared boost_system library.

This link is unneeded, so remove boost_system from the link list.
This fixes things for people who depend on the json manifest.

Fixes #7435

@planetmarshall
Please check this


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

All green in build 1 (cfbc22ab588c7ba6022d814d1128a700c4d16e6f):

  • boost/1.69.0@:
    All packages built successfully! (All logs)

  • boost/1.71.0@:
    All packages built successfully! (All logs)

  • boost/1.70.0@:
    All packages built successfully! (All logs)

  • boost/1.74.0@:
    All packages built successfully! (All logs)

  • boost/1.73.0@:
    All packages built successfully! (All logs)

  • boost/1.77.0@:
    All packages built successfully! (All logs)

  • boost/1.75.0@:
    All packages built successfully! (All logs)

  • boost/1.76.0@:
    All packages built successfully! (All logs)

  • boost/1.72.0@:
    All packages built successfully! (All logs)

@SSE4 SSE4 requested a review from uilianries October 2, 2021 09:34
@ghost ghost mentioned this pull request Oct 2, 2021
4 tasks
@planetmarshall
Copy link
Contributor

Looks good to me.

@conan-center-bot conan-center-bot requested a review from SSE4 October 5, 2021 11:57
@conan-center-bot conan-center-bot merged commit c9dd6e6 into conan-io:master Oct 6, 2021
@madebr madebr deleted the dont-link-to-boost_system branch October 6, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[boost] libraries built with dependency on boost::system, which is not included in the manifest
6 participants