-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NSIMD 2.2 #6790
Add NSIMD 2.2 #6790
Conversation
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Michael Keck <[email protected]>
This comment has been minimized.
This comment has been minimized.
recipes/nsimd/2.x/conanfile.py
Outdated
|
||
def _configure_cmake(self): | ||
python_cmd = sys.executable | ||
self.run("%s egg/hatch.py -ltf" % python_cmd, cwd=self._source_subfolder) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious, what is this egg hatch
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's their source code generator. It appears to be called automatically now, but it was required in v1.0:
https://github.com/agenium-scale/nsimd/tree/v1.0
I doubt there's interest in older versions of NSIMD so I'll just take it out.
#include <nsimd/nsimd-all.hpp> | ||
|
||
int main() { | ||
nsimd::pack<float> v; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: if possible, calling some method would be nice (like computing sum of two vectors?)
but instantiation is good as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. I've now added some sample code from the library's docs.
Remove explicit egg/hatch command.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I'm not sure what this build failure means. It builds locally with the gcc7 docker image. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super minor comments! Very close
Co-authored-by: Chris Mc <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing to sneak in
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Chris Mc <[email protected]>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Uilian Ries <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
All green in build 14 (
|
Specify library name and version: nsimd/2.2
This is a new recipe. I'm not the author, but I'm using it for some closed source projects. There is already a recipe for xsimd but nsimd's feature set is different.
closes #6789
Thanks!
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
conan-center hook activated.