Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NSIMD 2.2 #6790

Merged
merged 14 commits into from
Sep 10, 2021
Merged

Add NSIMD 2.2 #6790

merged 14 commits into from
Sep 10, 2021

Conversation

gmeeker
Copy link
Contributor

@gmeeker gmeeker commented Aug 9, 2021

Specify library name and version: nsimd/2.2

This is a new recipe. I'm not the author, but I'm using it for some closed source projects. There is already a recipe for xsimd but nsimd's feature set is different.

closes #6789

Thanks!
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.


def _configure_cmake(self):
python_cmd = sys.executable
self.run("%s egg/hatch.py -ltf" % python_cmd, cwd=self._source_subfolder)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious, what is this egg hatch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's their source code generator. It appears to be called automatically now, but it was required in v1.0:
https://github.com/agenium-scale/nsimd/tree/v1.0
I doubt there's interest in older versions of NSIMD so I'll just take it out.

#include <nsimd/nsimd-all.hpp>

int main() {
nsimd::pack<float> v;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: if possible, calling some method would be nice (like computing sum of two vectors?)
but instantiation is good as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. I've now added some sample code from the library's docs.

SSE4
SSE4 previously approved these changes Aug 10, 2021
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@gmeeker
Copy link
Contributor Author

gmeeker commented Aug 10, 2021

I'm not sure what this build failure means. It builds locally with the gcc7 docker image.

@gmeeker gmeeker closed this Aug 11, 2021
@gmeeker gmeeker reopened this Aug 11, 2021
@conan-center-bot

This comment has been minimized.

@CLAassistant
Copy link

CLAassistant commented Aug 13, 2021

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super minor comments! Very close

recipes/nsimd/2.x/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/nsimd/2.x/conanfile.py Outdated Show resolved Hide resolved
recipes/nsimd/2.x/test_package/conanfile.py Outdated Show resolved Hide resolved
Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing to sneak in

recipes/nsimd/2.x/test_package/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

recipes/nsimd/2.x/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/nsimd/2.x/conanfile.py Outdated Show resolved Hide resolved
recipes/nsimd/2.x/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

All green in build 14 (8bf7b267cc16bbd1c7ce422d7be230b61e0dafc4):

  • nsimd/2.2@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 58e57a6 into conan-io:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] nsimd/2.2
8 participants