Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catch2 version 2.9.2 #51

Merged
merged 4 commits into from
Sep 23, 2019
Merged

Conversation

Minimonium
Copy link
Contributor

@Minimonium Minimonium commented Sep 14, 2019

Specify library name and version: catch2/2.9.2

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@CLAassistant
Copy link

CLAassistant commented Sep 14, 2019

CLA assistant check
All committers have signed the CLA.

@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

@Minimonium
Copy link
Contributor Author

It seems I have the same problem as here 🙂 :
#50 (comment)

url = "https://github.com/catchorg/Catch2"
homepage = url
license = "BSL-1.0"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add your name as author 😺

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After Cppcon, Martin, the Catch2's maintainer, could be willing to pick up the authorship.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you there at cppcon?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly no. 🙂

@uilianries
Copy link
Member

You need to add a config.yml file to describe the version.

versions:
  "2.9.2":
    folder: 2.x.x

e.g. https://github.com/conan-io/conan-center-index/blob/master/recipes/fmt/config.yml

@Minimonium
Copy link
Contributor Author

@uilianries
Copy link
Member

oh boy, I didn't see it! sorry!

@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

@lasote
Copy link
Contributor

lasote commented Sep 15, 2019

Fixed your EAP.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'catch2/2.9.2' have failed:

@Minimonium
Copy link
Contributor Author

Question, since Catch2 supports minimum the C++11, how to define it for the CI to understand?

@SSE4
Copy link
Contributor

SSE4 commented Sep 15, 2019

need to raise ConanInvalidConfiguration for unsupported builds

@lasote
Copy link
Contributor

lasote commented Sep 15, 2019

That's a good question, because we are not applying different cppstd settings values in the input profiles. Catch2 is header only right? So it needs the "test_package" code to enable de c++11 support. But we don't want to raise ConanInvalidConfiguration in the catch2, if the recipe is correct, the package_id for all the applied configurations should be the same (header only).
We don't have an answer yet, could you please open an issue?
In the meantime might be ok to enable the CXX11 in the CMakeLists of the test_package.

@conan-center-bot
Copy link
Collaborator

All green! 😊

  • catch2/2.9.2: Generated 1 packages

@Minimonium
Copy link
Contributor Author

For the standard version requirement problem: #54

@lasote lasote merged commit 11e746a into conan-io:master Sep 23, 2019
@Minimonium Minimonium deleted the feature/catch2 branch June 16, 2020 16:59
artem-kamyshev pushed a commit to artem-kamyshev/conan-center-index that referenced this pull request Sep 28, 2020
use compiler and arch in package_id generation for protoc
datalogics-robb pushed a commit to datalogics-robb/conan-center-index that referenced this pull request May 4, 2023
Resolve CMake merge conflicts from conan-io, add saharay as assignee and reviewer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants