Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zoe: add version 3.5 #25978

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

zoe: add version 3.5 #25978

wants to merge 2 commits into from

Conversation

toge
Copy link
Contributor

@toge toge commented Nov 19, 2024

Summary

Changes to recipe: zoe/3.5

Motivation

  • disable SHA1
  • support macOS without patch

Details

winsoft666/zoe@v3.3...v3.5

This was referenced Nov 19, 2024
Open
Closed
@AbrilRBS AbrilRBS self-assigned this Nov 19, 2024
AbrilRBS
AbrilRBS approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

AbrilRBS
AbrilRBS requested changes Nov 19, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking a potential issue with curl requirement, sec

AbrilRBS
AbrilRBS previously approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

False alarm, all looks good on my end, sorry for the scare :)

@AbrilRBS AbrilRBS mentioned this pull request Nov 19, 2024
Closed
AbrilRBS
AbrilRBS reviewed Nov 19, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking yet again, sorry @toge! The release currently has 3.4 in the CMakeLists, see winsoft666/zoe#36

@toge
Copy link
Contributor Author

toge commented Nov 19, 2024

@AbrilRBS
Thank you for your improvements!
I have not addressed this version difference until now as it is not relevant to packaging, but I will submit an update request to upstream in the future.

@AbrilRBS
Copy link
Member

AbrilRBS commented Nov 19, 2024 •
edited
Loading

Yes, I see why this would be a non-issue. I think in this case the question would be wether a new release to fix this would happen soon/(a re-tag is also possible but less desired), or if 3.6/3.5.1 is still a ways off, we can then merge as-is. Do you have any insight into that? Thanks!

@toge
Copy link
Contributor Author

toge commented Nov 19, 2024

@AbrilRBS
I agree with you.

@AbrilRBS
Copy link
Member

Feel free to ping me once this is ready to go, thanks as always @toge we appreciate it :) <3

@toge toge marked this pull request as draft November 22, 2024 14:48
@toge toge marked this pull request as ready for review November 27, 2024 18:09
AbrilRBS
AbrilRBS approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toge @AbrilRBS