Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boost 1.86.0 recipe for x86 arch #25887

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

adaviding
Copy link
Contributor

@adaviding adaviding commented Nov 8, 2024

Summary

Changes to recipe: boost/1.86.0

Motivation

Fix #25864.

Details

We can see the relevant part of the build definition for boost 1.86.0 here. The token $(arch:G=) will evaluate to x86 in two conan recipe scenarios:

  • settings.arch = "x86"
  • settings.arch = "x86_64"

We also see an existing helper property _b2_architecture in the conan recipe here.

Therefore this change seems reasonable.

Testing

profile "win32_v192_debug.txt"

VS 2019 16.11.41

[settings]
arch=x86
build_type=Debug
compiler=msvc
compiler.runtime=dynamic
compiler.runtime_type=Debug
compiler.version=192
os=Windows

profile "x64_v192_debug.txt"

VS 2019 16.11.41

[settings]
arch=x86_64
build_type=Debug
compiler=msvc
compiler.runtime=dynamic
compiler.runtime_type=Debug
compiler.version=192
os=Windows

profile "win32_v194_debug.txt"

VS 2022 17.11.5

[settings]
arch=x86
build_type=Debug
compiler=msvc
compiler.runtime=dynamic
compiler.runtime_type=Debug
compiler.version=194
os=Windows

profile "x64_v194_debug.txt"

VS 2022 17.11.5

[settings]
arch=x86_64
build_type=Debug
compiler=msvc
compiler.runtime=dynamic
compiler.runtime_type=Debug
compiler.version=194
os=Windows

cases

Using Conan 2.9.2:

  • conan create ./all --version 1.86.0 --build missing --profile:all "C:\tmp\conan_profiles\win32_v192_debug.txt"
  • conan create ./all --version 1.86.0 --build missing --profile:all "C:\tmp\conan_profiles\x64_v192_debug.txt"
  • conan create ./all --version 1.86.0 --build missing --profile:all "C:\tmp\conan_profiles\win32_v194_debug.txt"
  • conan create ./all --version 1.86.0 --build missing --profile:all "C:\tmp\conan_profiles\x64_v194_debug.txt"

@adaviding adaviding mentioned this pull request Nov 8, 2024
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uilianries uilianries self-assigned this Nov 9, 2024
@jcar87
Copy link
Contributor

jcar87 commented Nov 9, 2024

Thanks @adaviding - please be aware that as of this week we have stopped supporting Conan 1.x in Conan Center - so while the fix is correct, it will only be made available for Conan 2.x onwards.

@adaviding
Copy link
Contributor Author

@pya102 @robomics @SpaceIm @tpaustian I need one more review for this PR. Looking at the commit history for boost, you are the last 4 (besides Uilian) to touch it. I just need 1 of you.

BTW -- GitHub does not allow me to request a review in the normal way. (It appears to be a permission issue.)

@robomics
Copy link
Contributor

@adaviding I believe you need one more approval from someone with write access to this repo.
Unfortunately I am a regular user, so I cannot help you.

@jcar87 jcar87 merged commit 496967c into conan-io:master Nov 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] boost/1.86.0: x86 build, libboost_stacktrace_from_exception library not used in any boost module
4 participants