Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost: correct address model for "s390x" architecture #25789

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

pya102
Copy link
Contributor

@pya102 pya102 commented Nov 1, 2024

Added "s390x" to the _b2_address_model function to return "64".

Summary

Changes to recipe: lib/all

Motivation

Boost library fails to build on IBM Z and IBM LinuxONE processors due to recipe defaulting to 32-bits architecture due to the following function:

def _b2_address_model(self):
        if self.settings.arch in ("x86_64", "ppc64", "ppc64le", "mips64", "armv8", "armv8.3", "sparcv9"):
             return "64"

        return "32"

Details

Added "s390x" to the architecture tuple returning "64":

def _b2_address_model(self):
       if self.settings.arch in ("x86_64", "ppc64", "ppc64le", "mips64", "armv8", "armv8.3", "sparcv9", "s390x"):
            return "64"

        return "32"

Added "s390x" to the  _b2_address_model function to return "64".
@CLAassistant
Copy link

CLAassistant commented Nov 1, 2024

CLA assistant check
All committers have signed the CLA.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

@pya102 pya102 mentioned this pull request Nov 2, 2024
@AbrilRBS AbrilRBS self-assigned this Nov 2, 2024
Copy link
Contributor

@jcar87 jcar87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is fine, just double checking something on CI :)

@jcar87 jcar87 changed the title Update conanfile.py Boost: correct address model for "s390x" architecture Nov 6, 2024
Copy link
Contributor

@jcar87 jcar87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pya102 - We don't have a way to test this, but all info I can find online points to that architecture being 64-bit .

@AbrilRBS AbrilRBS merged commit 33273bd into conan-io:master Nov 6, 2024
22 checks passed
@pya102
Copy link
Contributor Author

pya102 commented Nov 7, 2024

Thank you so much for your response.

If interested, IBM provides access to Virtual Machines using s390x architecture to Open Source projects like this one. You can request access using this link: https://community.ibm.com/zsystems/form/l1cc-oss-vm-request/

I look forward to continuing to contribute to the community.

@pya102 pya102 deleted the patch-1 branch November 7, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants