-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libxml2: Add version 2.13.4, fixes a few CVE issues #25322
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hey @gsantner , thanks a lot for your contribution, but wouldn’t it be better to use the latest version 2.13.4 if the goal is to stay up to date? |
@ErniGH My PR initially contained the 2.13 one, but Conan fails to build with that. Having a no-new-features version available is fine too, even with knowing that 2.13 could break some other recipes in turn. If somebody with more sophisticated Conan recipe knowledge wants to take a look fine too, but I myself suggest only the version bumps when noticing. |
@gsantner Thank you for your PR. Checking the previous build log on Windows: It failed because Could you please revert your latest commit and getting back 2.13 instead. Then, update the recipe with the follow change: def config_options(self):
...
if Version(self.version) >= "2.13.0":
self.options.rm_safe("mem-debug") Regards! |
@uilianries Let's see what the CI says 😄 |
It failed again. pdb files not created but tried to copy? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@gsantner It seems like it's missing some symbols. I'll take a look by Monday. Thank you again! |
Thanks for help! |
@uilianries @gsantner the issue was a missing bcrypt dependency in the new version, see https://gitlab.gnome.org/GNOME/libxml2/-/blob/2.13/win32/Makefile.msvc?ref_type=heads#L84 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked https://gitlab.gnome.org/GNOME/libxml2/-/compare/2.12...2.13?from_project_id=1665&page=2&straight=false, seems like we're not missing anything else, thanks!
This comment has been minimized.
This comment has been minimized.
@AbrilRBS Thank you so much!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice addition pointing the origin of bcrypt as dependency.
Update on this: We'll be merging this PR this Wednesday, and run the necessary builds on our end to avoid missing binaries, thanks a lot for taking the time to create the PR, there are no futher actions you need to take, we'll take it from here :) Just for traceability's shake, the necessary packages we'll rebuild are:
/cc @uilianries |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 8 (
Conan v2 pipeline ✔️
All green in build 8 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hello @AbrilRBS , Is this reproducable on msvc on CI too? |
@gsantner I'll take a look now, thanks for the ping. What error are you seeing? Is this in linux? |
@AbrilRBS |
Thanks for fixing it! 😄 |
Summary
Changes to recipe: libxml2
Motivation
Stay up to date with somewhat recent releases of upstream, fix CVE issues. Update to latest patch version.
See also: https://gitlab.gnome.org/GNOME/libxml2/-/releases
Details
Version bump