-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libsodium: add version 1.0.20 #25321
Conversation
This comment has been minimized.
This comment has been minimized.
What is holding this PR? |
@ErniGH is there anything I can do to help? I was going to start making small contributions to conan anyway so this can be my starting point as well. |
@kubasejdak Any contributor should first request access on the issue #4, as mentioned by the automatic message above. Plus, it's documented here: https://github.com/conan-io/conan-center-index/tree/master/docs/adding_packages#one-request-access @nonovv Please, comment on the issue #4, so we can add you the the contributors list. Sorry the delay, this inclusion process should be improved in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I see no breaking changes between those patch versions: jedisct1/libsodium@1.0.19-RELEASE...1.0.20-RELEASE#diff-49473dca262eeab3b4a43002adb08b4db31020d190caaad1594b47f1d5daa810
Conan v1 pipeline ✔️Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. All green in build 3 (
Conan v2 pipeline ✔️
All green in build 2 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR has been automatically merged due to |
Summary
Changes to recipe: libsodium/1.0.20
fork from qchateau
Motivation
mainly addressing compilation issues
Details