-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fire-hpp: add version 1.0 #25317
fire-hpp: add version 1.0 #25317
Conversation
This comment has been minimized.
This comment has been minimized.
recipes/fire-hpp/all/conandata.yml
Outdated
@@ -1,4 +1,7 @@ | |||
sources: | |||
"1.0": | |||
url: "https://github.com/kongaskristjan/fire-hpp/archive/v0.2.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @toge, the URL is from the previous version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ErniGH
Sorry, I fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @toge!
I see in https://github.com/kongaskristjan/fire-hpp/blob/master/docs/conan.md that upstream expects users to use their own conanfile. Maybe we could opena. PR to also mention the usual conan install --requires=fire-hpp/1.0
approach, what do you think? Are you up for it? :)
Summary
Changes to recipe: fire-hpp/1.0
Motivation
This is the first stable release.
Details
kongaskristjan/fire-hpp@v0.2...v1.0