Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: spirv-tools/[*]
Motivation
The
spirv-tools
recipe currently incorrectly builds several components as static whenshared=True
and skips packaging of them. This means thatspirv-tools
can only be used withshared=False
when used together withglslang
:conan-center-index/recipes/glslang/all/conanfile.py
Lines 72 to 76 in a7603e7
This limitation is only imposed by inconsistent naming of the CMake targets and Windows shared build issues: KhronosGroup/SPIRV-Tools#3909
Both of these can be worked around in the recipe while making the shared build actually usable on non-Windows systems.
Details
I have not tested the shared build on Windows yet.