Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libraw: fix inconsistencies with upstream project #25302

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Sep 18, 2024

Summary

Changes to recipe: libraw/[*]

Motivation

The recipe uses a custom CMakelists.txt, which does not completely reproduce the logic in the project build scripts:

  • The project builds two separate libraries - raw and raw_r. The only difference for the latter is that it's built with -pthread. I added it as an optional component to the recipe to avoid linking against both by accident in consuming recipes.
  • The .pc files installed by the project include a -Iinclude/libraw compile flag not set by the recipe.
  • The library provides a pure-C interface, but it requires linking against the C++ stdlib in that case.

The missing include dir path caused a compilation failure in imlib2.

Details


@valgur valgur mentioned this pull request Sep 18, 2024
5 tasks
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (6bee75cf50ff1bf8d3cfe3a778f247f5d4e896b8):

  • libraw/0.21.2:
    All packages built successfully! (All logs)

  • libraw/0.20.2:
    All packages built successfully! (All logs)

  • libraw/0.21.1:
    All packages built successfully! (All logs)

  • libraw/0.20.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (6bee75cf50ff1bf8d3cfe3a778f247f5d4e896b8):

  • libraw/0.21.1:
    All packages built successfully! (All logs)

  • libraw/0.20.2:
    All packages built successfully! (All logs)

  • libraw/0.21.2:
    All packages built successfully! (All logs)

  • libraw/0.20.0:
    All packages built successfully! (All logs)

@AbrilRBS AbrilRBS self-assigned this Sep 18, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking the time to fix the recipe usage, and the detailed PR description, we appreciate it :)

The changes look good to me

Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit d734781 into conan-io:master Sep 19, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants