-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hermes: add recipe #24010
hermes: add recipe #24010
Conversation
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 86bbb44hermes/0.12.0@#7a1bd4a27244a625b64fbe4bf305cbe9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Some initial comments :)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@RubenRBS |
We have now fixed this, relaunching! :) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit d37bcd4hermes/2024.04.29@#fd63a78c4c1be0fa639c6e618fda7062
|
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 37076dbhermes/2024.04.29@#490d369d8fcefa31cb62b1a51aee943e
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I have been trying to make this work, but it is being a bit of a challenge:
def build_requirements(self):
- self.tool_requires("cpython/3.12.2")
+ def validate_build(self):
+ if getattr(sys, "frozen", False):
+ raise ConanInvalidConfiguration("This package cannot be built with a Conan self-contained executable, "
+ "needs full Python installation") And it seems it works, both in Windows and Linux so far, so I think it is worth removing that moving piece.
- tc.cache_variables["BUILD_SHARED_LIBS"] = self.options.shared
- tc.variables["HERMES_USE_STATIC_ICU"] = not self.dependencies["icu"].options.shared
- tc.variables["HERMES_ENABLE_TEST_SUITE"] = False
+ tc.cache_variables["HERMES_USE_STATIC_ICU"] = not self.dependencies["icu"].options.shared
+ tc.cache_variables["HERMES_ENABLE_TEST_SUITE"] = False
+ tc.cache_variables["HERMES_IS_ANDROID"] = self.settings.os == "Android"
+ tc.cache_variables["HERMES_ENABLE_WIN10_ICU_FALLBACK"] = False setting things like Android configuration.
Still, my Windows build is failing in the I am going to push the changes, I think it might help a bit, but please let me know. |
Conan v1 pipeline ❌Failure in build 13 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping Failure in build 15 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Specify library name and version: hermes/*