-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git: new recipe #23828
Open
Ahajha
wants to merge
15
commits into
conan-io:master
Choose a base branch
from
Ahajha:git-recipe
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
git: new recipe #23828
+249
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 16 (
Conan v2 pipeline ✔️
All green in build 16 (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: git/2.45.1
Resolves #23601
Note: The one potentially relevant patch has not been submitted upstream. Frankly, Git's mailing list scares me, and I don't think the changes here would be robust enough to be accepted, but should be good enough for our usage.
I am unsure what to do about some of the packaged files, as some seem harmless but are picked up by the hook, while some are bloating the package but could be useful. Here's the
tree
output on Linux, omitting thermdir
s in thepackage()
step (the contents ofbin
I believe should be agreeably useful):tree.txt
The
libexec/git-core
folder would likely need to be added to the path if we decide to keep it. These commands seem to be part of the normal Git installation (though on my machine they aren't on they're not on path for some reason). There's also a duplicategit
, so maybe only one of them is intended to be used? These are a ton of essentially extra copies ofgit
, which greatly bloats the package size. I think it's fine to omit these, but would love input.The
share
folder seems harmless (not big at all) but doesn't really contain much that would likely be useful for Conan users, mainly some perl scripts and some samples from what I can tell. Probably best to just make the hook happy and remove it.