Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libphonenumber: new recipe #23689

Merged
merged 15 commits into from
Jul 29, 2024
Merged

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Apr 21, 2024

Adds libphonenumber: https://github.com/google/libphonenumber

Google's common Java, C++ and JavaScript library for parsing, formatting, and validating international phone numbers.

I have tested the package with all of the options enabled and disabled. Everything worked as expected, except for:

  • use_re2=True failing with a compilation error,
  • use_icu_regexp=False failing when linking test_package.

Packaging status

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

recipes/libphonenumber/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2024

Thanks, @memsharded! I especially appreciate the effort you put into trying to get the MSVC build working, even if it's not really supported.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@memsharded
Copy link
Member

Probably not worth the effort to make it work in Conan 1, I think I'll revert the validate() part and exclude Conan 1 builds. I tried it locally and it worked with Linux gcc-11, this is why I also tried in CI.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 15 (b4da64337e02320b7217f153b19ed1e27ec3003b):

  • libphonenumber/8.13.42:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 15 (b4da64337e02320b7217f153b19ed1e27ec3003b):

  • libphonenumber/8.13.42:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit a3fefa5 into conan-io:master Jul 29, 2024
12 checks passed
@barbacar
Copy link

barbacar commented Sep 12, 2024

hello guys,@valgur @memsharded Is there a chance to add libphonenumber to Conan1 also? Thanks.

@memsharded
Copy link
Member

Hi @barbacar

I am afraid this wouldn't be a priority, at least for the maintainers, all efforts have shifted now to Conan 2 (released 19 months ago).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants