-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libphonenumber: new recipe #23689
libphonenumber: new recipe #23689
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7ce9f69
to
c9ff72e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
b00435d
to
730d3b4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Thanks, @memsharded! I especially appreciate the effort you put into trying to get the MSVC build working, even if it's not really supported. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Probably not worth the effort to make it work in Conan 1, I think I'll revert the |
This comment has been minimized.
This comment has been minimized.
This reverts commit bfdcdb7.
Conan v1 pipeline ✔️All green in build 15 (
Conan v2 pipeline ✔️
All green in build 15 (
|
hello guys,@valgur @memsharded Is there a chance to add libphonenumber to Conan1 also? Thanks. |
Hi @barbacar I am afraid this wouldn't be a priority, at least for the maintainers, all efforts have shifted now to Conan 2 (released 19 months ago). |
Adds libphonenumber: https://github.com/google/libphonenumber
Google's common Java, C++ and JavaScript library for parsing, formatting, and validating international phone numbers.
I have tested the package with all of the options enabled and disabled. Everything worked as expected, except for:
use_re2=True
failing with a compilation error,use_icu_regexp=False
failing when linking test_package.