Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small_gicp: new recipe #23458

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

small_gicp: new recipe #23458

wants to merge 13 commits into from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Apr 10, 2024

Adds small_gicp: https://github.com/koide3/small_gicp

small_gicp is a header-only C++ library that offers efficient and parallelized algorithms for fine point cloud registration (ICP, Point-to-Plane ICP, GICP, VGICP, etc.). It is a refined and optimized version of its predecessor, fast_gicp, re-written from scratch with the following features.

Requires LLVM OpenMP support on MSVC. Blocked by #22353.

/cc @koide3

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this Apr 15, 2024
AbrilRBS
AbrilRBS previously approved these changes Apr 15, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! :) The CI will pick this up once maintenance mode is removed

recipes/small_gicp/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 18 (deb3160542ed6b5fe4c069baa5bd38cb899aa01e):

  • small_gicp/1.0.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 18 (deb3160542ed6b5fe4c069baa5bd38cb899aa01e):

  • small_gicp/1.0.0:
    All packages built successfully! (All logs)

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valgur Suggestion for be able to move this forward, let me know what you think :)

Comment on lines +64 to +66
# '#pragma omp' is used in public headers
# Note: native MSVC OpenMP is not compatible
self.requires("llvm-openmp/18.1.8", transitive_headers=True, transitive_libs=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we validate() this configuration out to be able to move this forward while work on mp progresses?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants