Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sfml: Use libglvnd on FreeBSD and Linux #23448

Closed
wants to merge 1 commit into from

Conversation

jwillikers
Copy link
Contributor

The libglvnd package provides the necessary opengl/system dependency. The libglvnd package is a proper, non-system Conan package.

The libglvnd package provides the necessary opengl/system dependency.
The libglvnd package is a proper, non-system Conan package.
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (64e9e60b01dcb459649fa0649215154c1a70ca8d):

  • sfml/2.6.1:
    All packages built successfully! (All logs)

  • sfml/2.6.0:
    All packages built successfully! (All logs)

  • sfml/2.5.1:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (64e9e60b01dcb459649fa0649215154c1a70ca8d):

  • sfml/2.6.1:
    All packages built successfully! (All logs)

  • sfml/2.5.1:
    All packages built successfully! (All logs)

  • sfml/2.6.0:
    All packages built successfully! (All logs)

Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwillikers thanks a lot for the PR!

I was reading about the libglvnd. I did not know much about it to be honest (apart from the Changelog lines mentioned in this PR).
Now, I was wondering if we should set the CMake variable mentioned here: https://github.com/SFML/SFML/blob/d6e1961112c29eee7f60128c29ed699795505167/src/SFML/Window/CMakeLists.txt#L294-L299

@jwillikers
Copy link
Contributor Author

jwillikers commented Apr 18, 2024

@jwillikers thanks a lot for the PR!

I was reading about the libglvnd. I did not know much about it to be honest (apart from the Changelog lines mentioned in this PR). Now, I was wondering if we should set the CMake variable mentioned here: https://github.com/SFML/SFML/blob/d6e1961112c29eee7f60128c29ed699795505167/src/SFML/Window/CMakeLists.txt#L294-L299

Yes, I think so. That variable is a built-in one for CMake's FindOpenGL module. I've already set it in the generate method in this PR.

Also, it should be noted there's been further discussion on using libglvnd in PR #23439. I've opened PR's for every recipe that's up-to-date and uses opengl/system to migrate to the libglvnd package. I think there's only one that I'm aware of that is failing in CI, but that's because it uses its own homebrew build-system.

@jcar87
Copy link
Contributor

jcar87 commented Apr 19, 2024

Closing pending discussion at #23649

@jcar87 jcar87 closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants