Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implot: bump imgui for consistency with other packages #23434

Merged
merged 6 commits into from
Apr 20, 2024
Merged

implot: bump imgui for consistency with other packages #23434

merged 6 commits into from
Apr 20, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Apr 9, 2024 •
edited
Loading

Also adds support for v1.89.7+ for v0.14 by renaming a single imgui constant in a .cpp file.

IMGUI_DEFINE_MATH_OPERATORS no longer needs to be set in CMake. Dropped it to get rid of a related warning.

The imgui version bump is for compatibility with imguizmo (#23435) and iridescence (#23436). There are no other packages depending on implot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

🤖 Beep Boop! This pull request is making changes to 'recipes/implot//'.

👋 @Hopobcn you might be interested. 😉

This was referenced Apr 9, 2024
Merged
Closed
@prince-chrismc prince-chrismc mentioned this pull request Apr 9, 2024
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@AbrilRBS AbrilRBS self-assigned this Apr 10, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur changed the title implot: don't link a demo program into lib, bump imgui for consistency with other packages implot: bump imgui for consistency with other packages Apr 11, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 7 (31cf5302d4d1fdf57d8c858ae308675a135a86d9):

  • implot/0.16:
    All packages built successfully! (All logs)

  • implot/0.15:
    All packages built successfully! (All logs)

  • implot/0.14:
    All packages built successfully! (All logs)

  • implot/0.13:
    All packages built successfully! (All logs)

  • implot/0.11:
    All packages built successfully! (All logs)

  • implot/0.12:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 7 (31cf5302d4d1fdf57d8c858ae308675a135a86d9):

  • implot/0.15:
    All packages built successfully! (All logs)

  • implot/0.13:
    All packages built successfully! (All logs)

  • implot/0.14:
    All packages built successfully! (All logs)

  • implot/0.16:
    All packages built successfully! (All logs)

  • implot/0.12:
    All packages built successfully! (All logs)

  • implot/0.11:
    All packages built successfully! (All logs)

@valgur valgur requested a review from AbrilRBS April 20, 2024 10:52
@valgur
Copy link
Contributor Author

valgur commented Apr 20, 2024

@jwillikers @ericLemanissier @toge a community review would be welcome here

@conan-center-bot conan-center-bot merged commit 09e7942 into conan-io:master Apr 20, 2024
38 checks passed
franramirez688 pushed a commit to toge/conan-center-index that referenced this pull request Apr 23, 2024
@valgur @franramirez688
(conan-io#23434) implot: bump imgui for consistency with other packages
8f8443e 
* implot: don't build and link implot_demo.cpp

* implot: IMGUI_DEFINE_MATH_OPERATORS does not need to be defined since v0.16

* implot: bump imgui versions to latest supported ones

* implot: make v0.14 compatible with imgui/1.90.x

* implot: restore implot_demo.cpp, add a comment

* implot: bump imgui
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@ericLemanissier ericLemanissier ericLemanissier approved these changes

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@valgur @conan-center-bot @ericLemanissier @AbrilRBS