-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aerospike-client-c: new recipe #23356
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
fdde7d4
to
49090b4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit f7c1fb0aerospike-client-c/6.6.0@#589686ab9f385332ad840994456697ca
|
def layout(self): | ||
basic_layout(self, src_folder='src') | ||
|
||
def source(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, use source to download a tarball version instead. Using git is not allowed. Please, read https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/folders_and_files.md#the-recipe-folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay! Gonna fix it. I used git because source project use submodules and I decided that using git is a good idea. Can you suggest how to download sources for projects with submodules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ybogo Each submodule should be split as a Conan package in a separated PR.
f7c1fb0
to
a80af2f
Compare
Conan v1 pipeline ✔️All green in build 11 (
Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping See details:Failure in build 11 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Hooks produced the following warnings for commit a80af2faerospike-client-c/6.6.0@#d763e96964615129e09a97620389d948
|
Specify library name and version: aerospike-client-c/6.6.0
I am not an author of this package but I moving my pet project to use conan and I am using aerospike client in it. So I decided to create a recipe to manage all my dependencies with only one tool.
Closes #23243