-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lielab: new package and v0.1.1 #23113
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few minor tweaks required. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msparapa Thank you for your PR! Could you please sign the CLA commented in this PR? Also, your username is listed already in the authorized users.
On it. Sorry, my institution has a fairly slow turnaround with these things. |
Co-authored-by: Martin Valgur <[email protected]>
Co-authored-by: Martin Valgur <[email protected]>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Uilian Ries <[email protected]>
This comment has been minimized.
This comment has been minimized.
Hi @uilianries . I did not try locally with any of the conan-center hooks but I think otherwise it's good to go now. |
@msparapa Thank you for checking locally. I see this is a new recipe and missing the test package part. Would mind adding the test package folder and adding a very minimum test to validate the package? We have a template for header-only projects, so you don't start it from the scratch: https://github.com/conan-io/conan-center-index/tree/master/docs/package_templates/header_only/all |
I added the test package. Question though, as of v0.3.0, the way Lielab gets imported changes so the |
This comment has been minimized.
This comment has been minimized.
- Hopefully clean up the relative file import path errors.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi @uilianries . I think this is good to go now. I fixed some of the errors on the main branch and changed the version to 0.4.0 since it was the easiest thing to do. I think the remaining failures are from Conan v1 not using the |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 13 (
Conan v2 pipeline ✔️
All green in build 12 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Sorry the delay to review. I pushed a small fix to the test package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding new package to ConanCenter: Lielab.
lielab/0.1.1
I am the author of this library.