-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
freeglut: Use the mesa-glu package when not on Apple or Windows #22428
freeglut: Use the mesa-glu package when not on Apple or Windows #22428
Conversation
I detected other pull requests that are modifying freeglut/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
@jwillikers seems like it's not able to find the headers now :) |
Yes, looking into it, there's a couple of problems here. That older version doesn't even look for GLU for starters, and even if it did, using the |
I've opened CMake issue #25627 to address this issue. |
Looking into this further, it's failing for the |
I'm working on fixing this in CMake and have opened the issue freeglut/freeglut#153 to get this fixed there. |
Alright, fixed in CMake proper. I've opened freeglut/freeglut#154 to fix this in FreeGLUT. I think that it will be best if #20905 is merged before I attempt to add any patches to fix this here, as that will make porting the upstream patches much easier. |
Thanks a lot @jwillikers! It's great to see :) I'll focus on approving the PR to ease things a bit for you |
6e60396
to
c6e9f41
Compare
The glu/system package installs the Mesa GLU system package on Linux and FreeBSD. Now that the mesa-glu package is available in Conan, use that instead.
c6e9f41
to
602edc9
Compare
Conan v1 pipeline ✔️All green in build 3 (
Conan v2 pipeline ✔️
All green in build 3 ( |
@RubenRBS Alright, looks like everything is good to go now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is done the same way as for the FreeGLUT package in conan-io#22428. Requires conan-io#22956. Fixes conan-io#22944.
This is done the same way as for the FreeGLUT package in conan-io#22428. Fixes conan-io#22944.
This is done the same way as for the FreeGLUT package in conan-io#22428. Fixes conan-io#22944.
This is done the same way as for the FreeGLUT package in conan-io#22428. Fixes conan-io#22944.
The glu/system package installs the Mesa GLU system package on Linux and FreeBSD. Now that the mesa-glu package is available in Conan, use that instead.