Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minhook: add minhook/cci.20240114 recipe #22165

Merged
merged 5 commits into from
Jul 29, 2024
Merged

minhook: add minhook/cci.20240114 recipe #22165

merged 5 commits into from
Jul 29, 2024

Conversation

wu-vincent
Copy link
Contributor

@wu-vincent wu-vincent commented Jan 5, 2024 •
edited
Loading

Specify library name and version: minhook/cci.20240114

minhook is a x86/x64 API Hooking Library for Windows. It is a lightweight alternative to the Detours library. Although I am not the original author, I believe creating a Conan recipe for this useful library will benefit the community with easier integration and broader usage.

@CLAassistant
Copy link

CLAassistant commented Jan 5, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

Sign in to view
2 similar comments
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@prince-chrismc prince-chrismc mentioned this pull request Jan 5, 2024
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@AbrilRBS AbrilRBS self-assigned this Jan 5, 2024
@AbrilRBS
Copy link
Member

AbrilRBS commented Jan 5, 2024

Maybe we could ask the maintainers to also create a new release? The last one is from 2017!

@wu-vincent
Copy link
Contributor Author

wu-vincent commented Jan 8, 2024 •
edited
Loading

Hi, thank you for your suggestion. I completely agree that having the latest releases in Conan Center is ideal for ensuring the most up-to-date and stable versions are available. Someone raised an issue back in April 2023 to request a new release. Unfortunately, there hasn't been a response from the maintainer yet.

In light of this, I propose creating a cci version of the package (e.g., minhook/cci.20240108). This would enable users to benefit from the recent improvements while we await an official release. This approach has been adopted for other libraries in similar situations, such as detours/cci.20220630.

I'd appreciate your thoughts on this approach or any alternative suggestions you might have.

@conan-center-bot

This comment has been minimized.

Sign in to view
@AbrilRBS
Copy link
Member

@wu-vincent let's do that!

@wu-vincent wu-vincent changed the title minhook: add minhook/1.3.3 recipe minhook: add minhook/cci.20240114 recipe Jan 14, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
valgur
valgur suggested changes Mar 24, 2024
View reviewed changes
Copy link
Contributor

@valgur valgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one minor change required.

recipes/minhook/all/patches/cci.20240114-0001-increase-cmake-min.patch Outdated Show resolved Hide resolved
@wu-vincent
Copy link
Contributor Author

@valgur Thank you for the suggestion! I've made the change accordingly.

@conan-center-bot

This comment has been minimized.

Sign in to view
@ErniGH ErniGH mentioned this pull request Jun 14, 2024
Open
@perseoGI perseoGI self-requested a review July 4, 2024 10:45
memsharded
memsharded reviewed Jul 29, 2024
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, I'll try to give it a final push to get it merged.
Thanks for your contribution, and I apologize for the delays in reviewing, the load is simply overwhelming and prioritizing is very challenging.

recipes/minhook/all/conandata.yml Outdated
@@ -0,0 +1,9 @@
sources:
"cci.20240114":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will be updating this versioning scheme, to be more future-proof. I'll do it myself and contribute.

@memsharded memsharded self-assigned this Jul 29, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (d40b30ea894b911c5b0151dd52be2d47185ef029):

  • minhook/1.3.3.cci.20240629:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (d40b30ea894b911c5b0151dd52be2d47185ef029):

  • minhook/1.3.3.cci.20240629:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit de1245e into conan-io:master Jul 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@valgur valgur valgur approved these changes

@franramirez688 franramirez688 Awaiting requested review from franramirez688

@perseoGI perseoGI Awaiting requested review from perseoGI

Assignees

@AbrilRBS AbrilRBS

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wu-vincent @CLAassistant @conan-center-bot @AbrilRBS @valgur @memsharded