Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openslide: new recipe #21138

Merged
merged 13 commits into from
Sep 9, 2024
Merged

openslide: new recipe #21138

merged 13 commits into from
Sep 9, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Nov 14, 2023

Adds OpenSlide: https://github.com/openslide/openslide

An optional dependency for libvips (https://www.libvips.org/).

Packaging status

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added the Version conflict There is a version conflict when solving the dependencies graph label Nov 14, 2023
@conan-center-bot

This comment has been minimized.

Copy link

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

recipes/openslide/all/test_package/test_package.c Outdated Show resolved Hide resolved
self.requires("gdk-pixbuf/2.42.10")
self.requires("glib/2.78.1", force=True) # FIXME
self.requires("libdicom/1.0.5")
self.requires("libjpeg/9e")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libjpeg-turbo is faster and widely used. I'd recommend using it instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to, but due to dependency conflicts CCI has to stick to one variant of the library and has settled on libjpeg as the default. I personally hope that this is something that could be changed after the Conan 2.0 migration effort is complete.

I added an option for the choice of libjpeg variant at least.

@valgur
Copy link
Contributor Author

valgur commented Nov 15, 2023

Thanks for doing this!

@bgilbert No problem, thanks for dropping by and adding your review!

@conan-center-bot conan-center-bot added Missing dependencies Build failed due missing dependencies in Conan Center and removed Version conflict There is a version conflict when solving the dependencies graph labels Nov 15, 2023
@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this Nov 15, 2023
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Blocked by #21137

recipes/openslide/all/conanfile.py Show resolved Hide resolved
recipes/openslide/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added Version conflict There is a version conflict when solving the dependencies graph and removed Missing dependencies Build failed due missing dependencies in Conan Center labels Mar 6, 2024
@conan-center-bot

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Mar 6, 2024

Hooks produced the following warnings for commit 2349e5b
openslide/4.0.0@#2ba39da6931e441729a40a440a4c7331
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libopenslide.dylib' links to system library 'CoreText' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libopenslide.1.dylib' links to system library 'CoreText' but it is not in cpp_info.frameworks.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit be4c4ec
openslide/4.0.0@#d245e51ecda13480688a8d414b657a14
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libopenslide.dylib' links to system library 'CoreText' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libopenslide.1.dylib' links to system library 'CoreText' but it is not in cpp_info.frameworks.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 0bbc054
openslide/4.0.0@#1defe42dba7bb5f3d51fed494fe1e137
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libopenslide.dylib' links to system library 'CoreText' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libopenslide.1.dylib' links to system library 'CoreText' but it is not in cpp_info.frameworks.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

github-actions bot commented May 6, 2024

Hooks produced the following warnings for commit e08bfec
openslide/4.0.0@#f395c7949a3e829d86a94962deb5c772
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libopenslide.dylib' links to system library 'CoreText' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libopenslide.1.dylib' links to system library 'CoreText' but it is not in cpp_info.frameworks.

@valgur
Copy link
Contributor Author

valgur commented May 15, 2024

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Aug 2, 2024

Hooks produced the following warnings for commit c45a376
openslide/4.0.0@#8db8b0fc29f4224818e32eb403ac4c32
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libopenslide.dylib' links to system library 'CoreText' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libopenslide.1.dylib' links to system library 'CoreText' but it is not in cpp_info.frameworks.

@valgur valgur mentioned this pull request Aug 3, 2024
4 tasks
@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added Missing dependencies Build failed due missing dependencies in Conan Center and removed Version conflict There is a version conflict when solving the dependencies graph labels Aug 21, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot removed Failed Missing dependencies Build failed due missing dependencies in Conan Center labels Aug 21, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 9 (a59518fdbdfa83027113f54f72fcefb84c84e2ff):

  • openslide/4.0.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 9 (a59518fdbdfa83027113f54f72fcefb84c84e2ff):

  • openslide/4.0.0:
    All packages built successfully! (All logs)

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your efforts and patience, this looks great to go now :)

@valgur valgur requested a review from AbrilRBS August 22, 2024 18:52
@AbrilRBS AbrilRBS requested a review from danimtb August 22, 2024 20:17
@conan-center-bot conan-center-bot merged commit f30ecae into conan-io:master Sep 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants