-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openslide: new recipe #21138
openslide: new recipe #21138
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
recipes/openslide/all/conanfile.py
Outdated
self.requires("gdk-pixbuf/2.42.10") | ||
self.requires("glib/2.78.1", force=True) # FIXME | ||
self.requires("libdicom/1.0.5") | ||
self.requires("libjpeg/9e") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libjpeg-turbo is faster and widely used. I'd recommend using it instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would love to, but due to dependency conflicts CCI has to stick to one variant of the library and has settled on libjpeg
as the default. I personally hope that this is something that could be changed after the Conan 2.0 migration effort is complete.
I added an option for the choice of libjpeg
variant at least.
@bgilbert No problem, thanks for dropping by and adding your review! |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Blocked by #21137
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 2349e5bopenslide/4.0.0@#2ba39da6931e441729a40a440a4c7331
|
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit be4c4ecopenslide/4.0.0@#d245e51ecda13480688a8d414b657a14
|
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 0bbc054openslide/4.0.0@#1defe42dba7bb5f3d51fed494fe1e137
|
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit e08bfecopenslide/4.0.0@#f395c7949a3e829d86a94962deb5c772
|
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit c45a376openslide/4.0.0@#8db8b0fc29f4224818e32eb403ac4c32
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 9 (
Conan v2 pipeline ✔️
All green in build 9 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your efforts and patience, this looks great to go now :)
Adds OpenSlide: https://github.com/openslide/openslide
An optional dependency for libvips (https://www.libvips.org/).