Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freealut: add recipe #20851

Merged
merged 12 commits into from
Feb 26, 2024
Merged

freealut: add recipe #20851

merged 12 commits into from
Feb 26, 2024

Conversation

lucaskdc
Copy link
Contributor

Specify library name and version: freealut/1.1.0

Since many applications that use openal used alut together, and currently the conan center index contains only the recipe for the OpenAl Soft, thir PR adds the recipe for freealut.


@CLAassistant
Copy link

CLAassistant commented Oct 31, 2023

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@lucaskdc lucaskdc force-pushed the freealut branch 3 times, most recently from 45c4780 to 94a2e41 Compare October 31, 2023 16:43
@conan-center-bot

This comment has been minimized.

Copy link
Contributor

@valgur valgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall but should definitely set the package_type = "shared-library" and remove the shared option.

recipes/freealut/all/conanfile.py Outdated Show resolved Hide resolved
recipes/freealut/all/conanfile.py Outdated Show resolved Hide resolved
recipes/freealut/all/conanfile.py Outdated Show resolved Hide resolved
recipes/freealut/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/freealut/all/test_v1_package/conanfile.py Outdated Show resolved Hide resolved
recipes/freealut/all/conanfile.py Outdated Show resolved Hide resolved
@luizfeldmann
Copy link
Contributor

Looks good overall but should definitely set the package_type = "shared-library" and remove the shared option.

We need the static build for vxWorks

@lucaskdc lucaskdc force-pushed the freealut branch 2 times, most recently from 87794eb to 9addc3b Compare November 3, 2023 21:11
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@lucaskdc lucaskdc force-pushed the freealut branch 2 times, most recently from 52dab0c to 0218822 Compare November 7, 2023 17:51
@conan-center-bot

This comment has been minimized.

@lucaskdc
Copy link
Contributor Author

lucaskdc commented Nov 8, 2023

Looks good overall but should definitely set the package_type = "shared-library" and remove the shared option.

Since most recipes build as static lib by default (including the openal-soft), i changed this one to do like the grpc recipe. It allows to build as static, but if the freealut is built as shared lib it forces to use requirements as shared too to avoid binary duplication.

@lucaskdc
Copy link
Contributor Author

lucaskdc commented Nov 8, 2023

Looks good overall but should definitely set the package_type = "shared-library" and remove the shared option.

We need the static build for vxWorks

probably openal-soft won't build for vxworks, but i left the static option there just in case someone uses it on linux.

@conan-center-bot

This comment has been minimized.

@lucaskdc lucaskdc marked this pull request as draft November 27, 2023 10:26
@luizfeldmann
Copy link
Contributor

Hi @lucaskdc any progress here ?

freealut's cmake currently is using find_library instead of the package finders so it wouldn't get its public compile definitions.
This causes al.h be preprocessed as a dynamic library. Since Windows symbols are different for dynamic and static methods they aren't found.
@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 3648ec7
freealut/1.1.0@#d67093dc086d9b39a97064f12c4d67b0
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libalut.0.dylib' links to system library 'OpenAL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libalut.dylib' links to system library 'OpenAL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libalut.0.0.0.dylib' links to system library 'OpenAL' but it is not in cpp_info.frameworks.
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libalut.0.dylib, libalut.dylib, libalut.0.0.0.dylib

@lucaskdc lucaskdc marked this pull request as ready for review December 13, 2023 12:17
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 33 (53b9985366ea85dab45fdd276b29c5cbdd817f5f):

  • freealut/1.1.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 33 (53b9985366ea85dab45fdd276b29c5cbdd817f5f):

  • freealut/1.1.0:
    All packages built successfully! (All logs)

@luizfeldmann
Copy link
Contributor

@valgur @franramirez688 @uilianries
We request your review please.

@conan-center-bot conan-center-bot merged commit 584c8d8 into conan-io:master Feb 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants