-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
freealut: add recipe #20851
freealut: add recipe #20851
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
45c4780
to
94a2e41
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall but should definitely set the package_type = "shared-library"
and remove the shared
option.
We need the static build for vxWorks |
87794eb
to
9addc3b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
52dab0c
to
0218822
Compare
This comment has been minimized.
This comment has been minimized.
Since most recipes build as static lib by default (including the openal-soft), i changed this one to do like the grpc recipe. It allows to build as static, but if the freealut is built as shared lib it forces to use requirements as shared too to avoid binary duplication. |
probably openal-soft won't build for vxworks, but i left the static option there just in case someone uses it on linux. |
Co-authored-by: Uilian Ries <[email protected]>
Co-authored-by: Uilian Ries <[email protected]>
This comment has been minimized.
This comment has been minimized.
Hi @lucaskdc any progress here ? |
freealut's cmake currently is using find_library instead of the package finders so it wouldn't get its public compile definitions. This causes al.h be preprocessed as a dynamic library. Since Windows symbols are different for dynamic and static methods they aren't found.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 3648ec7freealut/1.1.0@#d67093dc086d9b39a97064f12c4d67b0
|
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 33 (
Conan v2 pipeline ✔️
All green in build 33 (
|
@valgur @franramirez688 @uilianries |
Specify library name and version: freealut/1.1.0
Since many applications that use openal used alut together, and currently the conan center index contains only the recipe for the OpenAl Soft, thir PR adds the recipe for freealut.