-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optick/1.4.0.0: new recipe #20546
optick/1.4.0.0: new recipe #20546
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR! Please, try to simplify your recipe a bit, running methods that are not used will only consume more CPU with no benefit.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 676b38doptick/1.4.0.0@#26b249931938eaf5aa6813806a3eca43
|
Hi @uilianries, |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
recipes/optick/all/conanfile.py
Outdated
if not is_msvc(self): | ||
raise ConanInvalidConfiguration(f"{self.ref} can be built only by Visual Studio and msvc.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luizfeldmann Why is it not working for other platforms. Looking at https://github.com/bombomby/optick/blob/1.4.0.0/CMakeLists.txt I see no restrictions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This project consists of 2 components:
- The profiler library, which is currently built in this recipe
- The GUI to receive the profiler data, which is a C# project and must build on Windows
I'm not sure how to handle this separation in Conan. Any ideas ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The profiler library, which is currently built in this recipe
Yes, and as far as I see, it generates for any platform:
- Windows:
optick/1.4.0.0: RUN: cmake --install "C:\J2\w\prod-v2\bsr@3\36200\eeccb\p\b\optic78d0377885876\b\build" --config Release --prefix "C:/J2/w/prod-v2/bsr@3/36200/eeccb/p/b/optic78d0377885876/p"
-- Installing: C:/J2/w/prod-v2/bsr@3/36200/eeccb/p/b/optic78d0377885876/p/lib/OptickCore.lib
-- Installing: C:/J2/w/prod-v2/bsr@3/36200/eeccb/p/b/optic78d0377885876/p/bin/OptickCore.dll
-- Installing: C:/J2/w/prod-v2/bsr@3/36200/eeccb/p/b/optic78d0377885876/p/include/optick.h
-- Installing: C:/J2/w/prod-v2/bsr@3/36200/eeccb/p/b/optic78d0377885876/p/include/optick.config.h
-- Installing: C:/J2/w/prod-v2/bsr@3/36200/eeccb/p/b/optic78d0377885876/p/lib/cmake/Optick/OptickTargets.cmake
-- Installing: C:/J2/w/prod-v2/bsr@3/36200/eeccb/p/b/optic78d0377885876/p/lib/cmake/Optick/OptickTargets-release.cmake
-- Installing: C:/J2/w/prod-v2/bsr@3/36200/eeccb/p/b/optic78d0377885876/p/lib/cmake/Optick/OptickConfig.cmake
-- Installing: C:/J2/w/prod-v2/bsr@3/36200/eeccb/p/b/optic78d0377885876/p/lib/cmake/Optick/OptickConfigVersion.cmake
- Mac
Install the project...
cmake -P cmake_install.cmake
-- Install configuration: "Release"
-- Installing: /tmp/install/lib/libOptickCore.dylib
-- Installing: /tmp/install/include/optick.h
-- Installing: /tmp/install/include/optick.config.h
-- Installing: /tmp/install/lib/cmake/Optick/OptickTargets.cmake
-- Installing: /tmp/install/lib/cmake/Optick/OptickTargets-release.cmake
-- Installing: /tmp/install/lib/cmake/Optick/OptickConfig.cmake
-- Installing: /tmp/install/lib/cmake/Optick/OptickConfigVersion.cmake
So it should not block other platforms, as the main objective is package libraries and headers.
The GUI to receive the profiler data, which is a C# project and must build on Windows
How does it work? Is it a define in the header, a configuration file? Who generates it?
Conan v1 pipeline ✔️All green in build 11 (
Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping See details:Failure in build 11 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Hooks produced the following warnings for commit 3662d68optick/1.4.0.0@#656e7e1a90baae35a78979a119cbe4e9
|
Specify library name and version: optick/1.4.0.0