Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libblkid: Add recipe #20373

Closed
wants to merge 1 commit into from
Closed

libblkid: Add recipe #20373

wants to merge 1 commit into from

Conversation

jwillikers
Copy link
Contributor

Specify library name and version: libblkid/2.39

libblkid is part of the util-linux project.
It is currently packaged as part of the libmount package, but I need to depend on the libblkid library specifically in the eudev recipe, so I'm creating a separate package for it.
This will be the third Conan package broken out from the util-linux project.
I'm not sure if these could somehow be brought together in the future to reduce the maintenance overhead.
Anyways, the libmount recipe should be updated after this is merged to depend on this libblkid package instead of bundling the library itself.


@AbrilRBS
Copy link
Member

AbrilRBS commented Oct 5, 2023

I'm not sure if these could somehow be brought together in the future to reduce the maintenance overhead.

I'm adding this to our next team discussion, I'll let you know if we come up with anything for this :)

@jwillikers
Copy link
Contributor Author

I'm not sure if these could somehow be brought together in the future to reduce the maintenance overhead.

I'm adding this to our next team discussion, I'll let you know if we come up with anything for this :)

Thanks!

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (c69161563bf06b2b414865ee1a3183a3c3251fab):

  • libblkid/2.39:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (c69161563bf06b2b414865ee1a3183a3c3251fab):

  • libblkid/2.39:
    All packages built successfully! (All logs)

@AbrilRBS
Copy link
Member

Once concern: If I now have both this and libmount in the same graph, that will cause problems down the line, right?

@jwillikers
Copy link
Contributor Author

Once concern: If I now have both this and libmount in the same graph, that will cause problems down the line, right?

@RubenRBS Dang, I think you're right. The only way to mitigate that in a separate recipe is if util-linux allows building libmount with an external libblkid, which I doubt it supports.

Unfortunately, I think it would probably require a larger refactor of components to properly support these kinds of packages. The util-linux project in particular has licenses that apply to different components, which would require specifying the license field per component. It would also be great to somehow tie the components to a options to enable or disable them, which would make it easier to control which components get enabled by particular projects.

@@ -0,0 +1,4 @@
sources:
"2.39":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be bumped to 2.39.3.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 12, 2024
Copy link
Contributor

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@github-actions github-actions bot closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants