Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt-advanced-docking-system/all: Modernize to Conan V2 and add new version #20233

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leha-bot
Copy link
Contributor

Specify library name and version: qt-advanced-docking-system/all


@CLAassistant
Copy link

CLAassistant commented Sep 30, 2023

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@leha-bot leha-bot force-pushed the update-and-modernize-qt-adv-docking branch from 57e0fa9 to 84a5b86 Compare September 30, 2023 16:12
@conan-center-bot

This comment has been minimized.

@leha-bot leha-bot force-pushed the update-and-modernize-qt-adv-docking branch from 84a5b86 to eb0874c Compare October 6, 2023 17:05
@conan-center-bot

This comment has been minimized.

@leha-bot
Copy link
Contributor Author

leha-bot commented Nov 7, 2023

I would like to merge my PR after #18794 😊

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link

stale bot commented Dec 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@leha-bot leha-bot force-pushed the update-and-modernize-qt-adv-docking branch from b37d3c1 to 485388f Compare January 2, 2024 20:03
@conan-center-bot

This comment has been minimized.

@leha-bot leha-bot force-pushed the update-and-modernize-qt-adv-docking branch from 485388f to 4fd300a Compare April 17, 2024 14:01
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Changes not allowed in build 1:

[libidn2, qt-advanced-docking-system, libidn2]

Only one library can be changed in the same PR.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Changes not allowed in build 1:

[libidn2, qt-advanced-docking-system, libidn2]

Only one library can be changed in the same PR.

@paulharris
Copy link
Contributor

Any progress on this?

@leha-bot
Copy link
Contributor Author

leha-bot commented Aug 1, 2024

Any progress on this?

I'm currently blocked by #18794 , which is blocked by #24606, which is superseded by #24642 which has been merged 3 days ago, so I think that I will continue work on my PR soon.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 1, 2024
@leha-bot
Copy link
Contributor Author

leha-bot commented Oct 1, 2024

No, it's not stale, it's blocked for now

@github-actions github-actions bot removed the stale label Oct 2, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 1, 2024
@DonOregano
Copy link
Contributor

I started making a packaging of this library too (#25848). This appeared stale :-D
I am quite a noob at creating conan packages, though. So it is a basic attempt, but it works.

One thing that I would really like, is the ability to not use Qt from Conan. In my package I have an option qt_from_conan, which if set to False just builds the package with a Qt that is installed on the system. I have yet to work out a way to get the correct library name (qt5... or qt6...) in that case, however.

@github-actions github-actions bot removed the stale label Nov 7, 2024
@leha-bot
Copy link
Contributor Author

Stiil blocked by #18794 :(

@leha-bot
Copy link
Contributor Author

One thing that I would really like, is the ability to not use Qt from Conan. In my package I have an option qt_from_conan, which if set to False just builds the package with a Qt that is installed on the system. I have yet to work out a way to get the correct library name (qt5... or qt6...) in that case, however.

You may use the [platform_requires] from Conan profiles, for example, I am using it for system Perl for some internal packages.

@leha-bot leha-bot force-pushed the update-and-modernize-qt-adv-docking branch from 4fd300a to 6f34bf5 Compare November 21, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants