Add pcl PointCloudLibrary package #18389

EstebanDugueperoux2 · 2023-07-06T21:33:05Z

Inspired from #1891 but conan v2 compatible.

Specify library name and version: pcl/1.13.1

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

valgur

Overall looks good. Should add the missing optional requirements, though.

recipes/pcl/all/conanfile.py

recipes/pcl/all/patches/0001-flann-target-cmake.patch

recipes/pcl/all/conanfile.py

github-actions · 2023-07-08T12:16:27Z

Hooks produced the following warnings for commit 22112f3

pcl/1.13.1

post_package(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './include/pcl-1.13/pcl/registration/impl/transformation_estimation_point_to_plane_lls_weighted.hpp' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

github-actions · 2023-07-09T09:24:38Z

Hooks produced the following warnings for commit adc1a5f

pcl/1.13.1

post_package(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './include/pcl-1.13/pcl/registration/impl/transformation_estimation_point_to_plane_lls_weighted.hpp' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

recipes/pcl/all/conanfile.py

EstebanDugueperoux2 · 2023-07-09T12:15:49Z

Hi @jcar87, could you add pcl recipe to xlarge node to avoid pipelines to be killed because of memory consumption?

Regards.

recipes/pcl/all/patches/0001-KB-H020_avoid_pkgconfig_files.patch

Based on https://github.com/PointCloudLibrary/pcl/blob/3ed96c246e5c873713ec670b895469d09149a552/cmake/pcl_options.cmake#L49

pcl: restore zlib dep, adjust core types param

EstebanDugueperoux2 · 2023-08-14T17:49:29Z

Hi @jcar87 ,

Do you know what occurs in these pipelines?
I see "Unexpected Error" label and according to doc (https://github.com/conan-io/conan-center-index/blob/48d10319dedcc037ab7dc8452b691f4e76b57c5a/docs/labels.md#unexpected-error) these pipelines should be restarted but nothing occurs.

Regards.

EstebanDugueperoux2 · 2023-08-16T20:47:05Z

Thanks @jcar87 for the pipelines fixes.
All is green now, it miss a last reviewer to be able to merge this new recipe.

EstebanDugueperoux2 · 2023-08-17T10:06:24Z

Ping also @maksim-petukhov and @memsharded for a review.

maksim-petukhov · 2023-08-17T11:54:37Z

recipes/pcl/all/conanfile.py

+    def layout(self):
+        cmake_layout(self, src_folder="src")
+
+    def system_requirements(self):


I don't think pcl package should install any system dependencies. vtk is a library you can build from sources AFAIK. There is a TODO for self.requires("vtk/9.x.x", transitive_headers=True) in requirements function for adding vtk as a regular package in CCI.

I would keep it until we have a working VTK package in CCI, such as one from this PR #10776. Might take a while, though, given the complexity of that package.

I found a FAQ which forbids doing that. There is a hook but it doesn't work because it is not updated for tools under conan.tools.system.package_manager. I created an issue to fix the hook.

maksim-petukhov · 2023-08-17T11:57:34Z

recipes/pcl/all/conanfile.py

+
+        if self.settings.compiler.cppstd:
+            check_min_cppstd(self, self._min_cppstd)
+        minimum_version = self._compilers_minimum_version.get(str(self.settings.compiler), False)


I don't know the difference but I suppose that msvc minimum version should be checked with check_min_vs function call (see template)

They are equivalent. I preferred not using check_min_vs since it keeps the code simpler. The only downside is that Visual Studio and msvc are listed separately in the min versions dict.

maksim-petukhov · 2023-08-17T12:00:39Z

recipes/pcl/all/conanfile.py

+        "with_vtk": False,
+        # Enabled to avoid excessive memory usage during compilation in CCI
+        "precompile_only_core_point_types": True,
+        "add_build_type_postfix": False,


Why do we need this option and why the default is False? I see that pcl adds postfixes for Windows builds https://github.com/PointCloudLibrary/pcl/blob/b520a831182bc1d286bb2023093157f5796ad460/CMakeLists.txt#L40C7-L40C27

It avoids the headache of accounting for the different library suffixes depending on build_type and compiler. I did not see much value in keeping it enabled it with Conan, but it's easy enough to re-enable if necessary.

recipes/pcl/all/conanfile.py

conan-center-bot · 2023-08-18T01:37:16Z

Conan v1 pipeline ✔️

All green in build 30 (2415d909a32ea238d8d1785e8cf7c34292fcad37):

pcl/1.13.1:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 29 (2415d909a32ea238d8d1785e8cf7c34292fcad37):

pcl/1.13.1:
All packages built successfully! (All logs)

@maksim-petukhov

* Add pcl PointCloudLibrary package Inspired from conan-io#1891 * pcl: misc recipe tweaks * Update recipes/pcl/all/conanfile.py Co-authored-by: Martin Valgur <[email protected]> * pcl: Further fixes to Conan targets use in CMake * pcl: Fix buggy OpenNI detection if libusb missing * pcl: Fix PCL CMake config breaking OpenGL detection * pcl: Fix _add_component() bugs * pcl: add TODOs for missing Conan packages * pcl: set_property("cmake_find_mode", "both") * pcl: more accurate modelling of PCL components * pcl: tidy description * Enable opengl event if with_vtk is false - Enable opengl event if with_vtk is false as done in PCL CMakeLists.txt * Revert "Enable opengl event if with_vtk is false" This reverts commit c4be26d. * Enable opengl only if with_vtk==True * test is_msvc() method * test is_msvc_static_runtime * pcl: make components optional, add full dependency info * pcl: fixes to the component system * pcl: set OpenGL_GL_PREFERENCE=GLVND * pcl: fix _extra_libs handling * pcl: fix CUDA support * pcl: add all VTK system package variants * pcl: add missing transitive_headers=True based on installed header includes * pcl: add ws2_32 dep on Windows * Restore is_msvc_static_runtime import * pcl: fix Conan v1 issue * pcl: new add_build_type_postfix option, fix library naming on Windows * Take into account @maksim-petukhov remark * Take into account @valgur remark * Take into account maksim-petukhov remark * Set instantiate_only_core_point_types option at True * pcl: restore zlib dependency * pcl: adjust precompile_only_core_point_types name, add comment Based on https://github.com/PointCloudLibrary/pcl/blob/3ed96c246e5c873713ec670b895469d09149a552/cmake/pcl_options.cmake#L49 * Add rm to prevent PDBs files install --------- Co-authored-by: Martin Valgur <[email protected]>

ghost mentioned this pull request Jul 6, 2023

[service] Potentially conflicting recipes #3571

Closed

EstebanDugueperoux2 force-pushed the feature/AddPCL branch from c25afa2 to 01797f9 Compare July 7, 2023 07:42

conan-center-bot added the Failed label Jul 7, 2023

This comment has been minimized.

Sign in to view

valgur suggested changes Jul 7, 2023

View reviewed changes

recipes/pcl/all/conanfile.py Outdated Show resolved Hide resolved

recipes/pcl/all/conanfile.py Outdated Show resolved Hide resolved

recipes/pcl/all/patches/0001-flann-target-cmake.patch Outdated Show resolved Hide resolved

recipes/pcl/all/conanfile.py Outdated Show resolved Hide resolved

EstebanDugueperoux2 force-pushed the feature/AddPCL branch from 01797f9 to 22112f3 Compare July 8, 2023 11:31

This comment has been minimized.

Sign in to view

EstebanDugueperoux2 force-pushed the feature/AddPCL branch from 22112f3 to 4ea1e69 Compare July 8, 2023 17:02

This comment has been minimized.

Sign in to view

EstebanDugueperoux2 force-pushed the feature/AddPCL branch from 4ea1e69 to 4ca8691 Compare July 9, 2023 07:14

conan-center-bot added Unexpected Error and removed Failed labels Jul 9, 2023

This comment has been minimized.

Sign in to view

EstebanDugueperoux2 marked this pull request as ready for review July 9, 2023 07:48

prince-chrismc mentioned this pull request Jul 9, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

EstebanDugueperoux2 force-pushed the feature/AddPCL branch from 4ca8691 to adc1a5f Compare July 9, 2023 08:41

conan-center-bot added Failed and removed Unexpected Error labels Jul 9, 2023

This comment has been minimized.

Sign in to view

EstebanDugueperoux2 force-pushed the feature/AddPCL branch from adc1a5f to 2fc62d3 Compare July 9, 2023 09:57

This comment has been minimized.

Sign in to view

valgur reviewed Jul 9, 2023

View reviewed changes

recipes/pcl/all/conanfile.py Outdated Show resolved Hide resolved

EstebanDugueperoux2 force-pushed the feature/AddPCL branch from 2fc62d3 to db9dcc5 Compare July 9, 2023 10:37

This comment has been minimized.

Sign in to view

valgur reviewed Jul 9, 2023

View reviewed changes

recipes/pcl/all/patches/0001-KB-H020_avoid_pkgconfig_files.patch Outdated Show resolved Hide resolved

EstebanDugueperoux2 force-pushed the feature/AddPCL branch from db9dcc5 to 9175395 Compare July 10, 2023 19:18

This comment has been minimized.

Sign in to view

EstebanDugueperoux2 and others added 4 commits August 11, 2023 19:19

Set instantiate_only_core_point_types option at True

c26c415

pcl: restore zlib dependency

ec02bdd

pcl: adjust precompile_only_core_point_types name, add comment

fbd2246

Based on https://github.com/PointCloudLibrary/pcl/blob/3ed96c246e5c873713ec670b895469d09149a552/cmake/pcl_options.cmake#L49

Merge pull request #10 from valgur/feature/AddPCL

79c2797

pcl: restore zlib dep, adjust core types param

conan-center-bot added the Unexpected Error label Aug 11, 2023

This comment has been minimized.

Sign in to view

Merge branch 'master' into feature/AddPCL

24c68d1

This comment has been minimized.

Sign in to view

Merge branch 'master' into feature/AddPCL

2cb3b99

This comment has been minimized.

Sign in to view

conan-center-bot removed Unexpected Error Failed labels Aug 16, 2023

This comment has been minimized.

Sign in to view

EstebanDugueperoux2 requested review from maksim-petukhov and valgur August 16, 2023 20:45

maksim-petukhov reviewed Aug 17, 2023

View reviewed changes

Add rm to prevent PDBs files install

2415d90

EstebanDugueperoux2 requested a review from maksim-petukhov August 18, 2023 14:39

danimtb approved these changes Aug 21, 2023

View reviewed changes

jwillikers approved these changes Aug 22, 2023

View reviewed changes

conan-center-bot merged commit 9be5d79 into conan-io:master Aug 22, 2023
5 checks passed

This was referenced Aug 22, 2023

Add PCL package #1891

Closed

[question] What are the obstacles of merging PCL library for now? #10976

Closed

EstebanDugueperoux2 deleted the feature/AddPCL branch August 22, 2023 15:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add pcl PointCloudLibrary package #18389

Add pcl PointCloudLibrary package #18389

EstebanDugueperoux2 commented Jul 6, 2023 •

edited

Loading

This comment has been minimized.

valgur left a comment

This comment has been minimized.

github-actions bot commented Jul 8, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jul 9, 2023

This comment has been minimized.

EstebanDugueperoux2 commented Jul 9, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

EstebanDugueperoux2 commented Aug 14, 2023

This comment has been minimized.

EstebanDugueperoux2 commented Aug 16, 2023

EstebanDugueperoux2 commented Aug 17, 2023

maksim-petukhov Aug 17, 2023

valgur Aug 17, 2023

maksim-petukhov Aug 21, 2023 •

edited

Loading

maksim-petukhov Aug 17, 2023

valgur Aug 17, 2023

maksim-petukhov Aug 17, 2023

valgur Aug 17, 2023

conan-center-bot commented Aug 18, 2023

Add pcl PointCloudLibrary package #18389

Add pcl PointCloudLibrary package #18389

Conversation

EstebanDugueperoux2 commented Jul 6, 2023 • edited Loading

This comment has been minimized.

valgur left a comment

Choose a reason for hiding this comment

This comment has been minimized.

github-actions bot commented Jul 8, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jul 9, 2023

This comment has been minimized.

EstebanDugueperoux2 commented Jul 9, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

EstebanDugueperoux2 commented Aug 14, 2023

This comment has been minimized.

EstebanDugueperoux2 commented Aug 16, 2023

EstebanDugueperoux2 commented Aug 17, 2023

maksim-petukhov Aug 17, 2023

Choose a reason for hiding this comment

valgur Aug 17, 2023

Choose a reason for hiding this comment

maksim-petukhov Aug 21, 2023 • edited Loading

Choose a reason for hiding this comment

maksim-petukhov Aug 17, 2023

Choose a reason for hiding this comment

valgur Aug 17, 2023

Choose a reason for hiding this comment

maksim-petukhov Aug 17, 2023

Choose a reason for hiding this comment

valgur Aug 17, 2023

Choose a reason for hiding this comment

conan-center-bot commented Aug 18, 2023

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️

EstebanDugueperoux2 commented Jul 6, 2023 •

edited

Loading

maksim-petukhov Aug 21, 2023 •

edited

Loading