-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USearch: add version 0.18.8 #17700
USearch: add version 0.18.8 #17700
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi @ashvardanian thanks a lot for your contribution. The errors seem to come from your library code. Other than that, the recipe looks good to me, let us know once the upstream issue is resolved :) |
Co-authored-by: Rubén Rincón Blanco <[email protected]>
Co-authored-by: Rubén Rincón Blanco <[email protected]>
Co-authored-by: Rubén Rincón Blanco <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Please ping me when you manage to build this/let us know if you need any help! |
@RubenRBS I can't view the reason it fails in your CI - it reports the 403 forbidden error. Can you please check it up? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
USearch: Fix version mismatch
Co-authored-by: Uilian Ries <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution, and for your patience while we got this reviewed
The recipe looks great so let's get this merged :)
Conan v1 pipeline ❌Failure in build 6 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping See details:Failure in build 5 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Hey @RubenRBS! Can you please help me understand what's wrong with this recipe? Any help you need from me to merge this? |
@@ -0,0 +1,24 @@ | |||
#include <usearch/usearch.hpp> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashvardanian Here you are including <usearch/usearch.hpp>
, but here you copied only index.hpp
. The usearch is under c/
folder, but is part of the library usearch_c
.
So it's a bit confusing here, you are packing a header-only project, but including a library for testing package 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uilianries, oh, this is an artifact of our much older attempt. The usearch/index.hpp
should be included.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us know once the recipe changes are finished os we can re-review :)
license = "Apache-2.0" | ||
description = "Smaller & Faster Single-File Vector Search Engine from Unum" | ||
homepage = "https://github.com/unum-cloud/usearch" | ||
topics = ("search", "vector", "simd") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
topics = ("search", "vector", "simd") | |
topics = ("search", "vector", "simd", "header-only") |
I detected other pull requests that are modifying usearch/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
I am submitting usearch/0.8.0 to Conan.
The recipe was designed and tested with Conan v2.0.4 on MacOS.
And yes, I am the author of the project.