Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USearch: add version 0.18.8 #17700

Closed
wants to merge 14 commits into from
Closed

Conversation

ashvardanian
Copy link

I am submitting usearch/0.8.0 to Conan.
The recipe was designed and tested with Conan v2.0.4 on MacOS.
And yes, I am the author of the project.


@CLAassistant
Copy link

CLAassistant commented May 25, 2023

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

AbrilRBS
AbrilRBS previously approved these changes May 29, 2023
recipes/usearch/all/conanfile.py Outdated Show resolved Hide resolved
recipes/usearch/all/conanfile.py Outdated Show resolved Hide resolved
recipes/usearch/all/conanfile.py Outdated Show resolved Hide resolved
@AbrilRBS
Copy link
Member

Hi @ashvardanian thanks a lot for your contribution. The errors seem to come from your library code. Other than that, the recipe looks good to me, let us know once the upstream issue is resolved :)

Co-authored-by: Rubén Rincón Blanco <[email protected]>
ashvardanian and others added 2 commits May 31, 2023 00:51
Co-authored-by: Rubén Rincón Blanco <[email protected]>
Co-authored-by: Rubén Rincón Blanco <[email protected]>
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

Please ping me when you manage to build this/let us know if you need any help!

@ashvardanian ashvardanian changed the title usearch: add version 0.8.0 USearch: add version 0.18.8 Jun 21, 2023
@ashvardanian
Copy link
Author

@RubenRBS I can't view the reason it fails in your CI - it reports the 403 forbidden error. Can you please check it up?

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution, and for your patience while we got this reviewed

The recipe looks great so let's get this merged :)

@AbrilRBS AbrilRBS self-assigned this Sep 13, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 6 (47c80c38b18e56b1bdca0e02f1527d718bb4f4ae):

  • usearch/2.4.0:
    CI failed to create some packages (All logs)

    Logs for packageID 5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=5
    os=Linux
    
    [...]
    usearch/2.4.0 (test package): Generator 'CMakeToolchain' calling 'generate()'
    usearch/2.4.0 (test package): Preset 'release' added to CMakePresets.json. Invoke it manually using 'cmake --preset release'
    usearch/2.4.0 (test package): If your CMake version is not compatible with CMakePresets (<3.19) call cmake like: 'cmake <path> -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE=/home/conan/w/prod-v1/bsr/cci-ab84a080/recipes/usearch/all/test_package/build/Release/generators/conan_toolchain.cmake -DCMAKE_POLICY_DEFAULT_CMP0091=NEW -DCMAKE_BUILD_TYPE=Release'
    usearch/2.4.0 (test package): Generator 'CMakeDeps' calling 'generate()'
    usearch/2.4.0 (test package): Generator txt created conanbuildinfo.txt
    usearch/2.4.0 (test package): Generator 'VirtualRunEnv' calling 'generate()'
    usearch/2.4.0 (test package): Aggregating env generators
    usearch/2.4.0 (test package): Generated conaninfo.txt
    usearch/2.4.0 (test package): Generated graphinfo
    Using lockfile: '/home/conan/w/prod-v1/bsr/cci-ab84a080/recipes/usearch/all/test_package/build/Release/generators/conan.lock'
    Using cached profile from lockfile
    [HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] 'fPIC' option not found
    [HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] OK
    usearch/2.4.0 (test package): Calling build()
    usearch/2.4.0 (test package): CMake command: cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/home/conan/w/prod-v1/bsr/cci-ab84a080/recipes/usearch/all/test_package/build/Release/generators/conan_toolchain.cmake" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/home/conan/w/prod-v1/bsr/cci-ab84a080/recipes/usearch/all/test_package/."
    
    ----Running------
    > cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/home/conan/w/prod-v1/bsr/cci-ab84a080/recipes/usearch/all/test_package/build/Release/generators/conan_toolchain.cmake" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/home/conan/w/prod-v1/bsr/cci-ab84a080/recipes/usearch/all/test_package/."
    -----------------
    -- Using Conan toolchain: /home/conan/w/prod-v1/bsr/cci-ab84a080/recipes/usearch/all/test_package/build/Release/generators/conan_toolchain.cmake
    -- The CXX compiler identification is GNU 5.4.0
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Check for working CXX compiler: /usr/bin/g++ - skipped
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- Conan: Target declared 'usearch::usearch'
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /home/conan/w/prod-v1/bsr/cci-ab84a080/recipes/usearch/all/test_package/build/Release
    usearch/2.4.0 (test package): CMake command: cmake --build "/home/conan/w/prod-v1/bsr/cci-ab84a080/recipes/usearch/all/test_package/build/Release" '--' '-j3'
    
    ----Running------
    > cmake --build "/home/conan/w/prod-v1/bsr/cci-ab84a080/recipes/usearch/all/test_package/build/Release" '--' '-j3'
    -----------------
    Scanning dependencies of target test_package
    [ 50%] Building CXX object CMakeFiles/test_package.dir/test_package.cpp.o
    CMakeFiles/test_package.dir/build.make:81: recipe for target 'CMakeFiles/test_package.dir/test_package.cpp.o' failed
    CMakeFiles/Makefile2:94: recipe for target 'CMakeFiles/test_package.dir/all' failed
    Makefile:102: recipe for target 'all' failed
    /home/conan/w/prod-v1/bsr/cci-ab84a080/recipes/usearch/all/test_package/test_package.cpp:1:31: fatal error: usearch/usearch.hpp: No such file or directory
    compilation terminated.
    make[2]: *** [CMakeFiles/test_package.dir/test_package.cpp.o] Error 1
    make[1]: *** [CMakeFiles/test_package.dir/all] Error 2
    make: *** [all] Error 2
    usearch/2.4.0 (test package): WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    usearch/2.4.0 (test package): WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    ERROR: usearch/2.4.0 (test package): Error in build() method, line 21
    	cmake.build()
    	ConanException: Error 2 while executing cmake --build "/home/conan/w/prod-v1/bsr/cci-ab84a080/recipes/usearch/all/test_package/build/Release" '--' '-j3'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 5 (47c80c38b18e56b1bdca0e02f1527d718bb4f4ae):

  • usearch/2.4.0:
    CI failed to create some packages (All logs)

    Logs for packageID da39a3ee5e6b4b0d3255bfef95601890afd80709:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.cppstd=17
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    
    [...]
    usearch/2.4.0 (test package): Generator 'CMakeToolchain' calling 'generate()'
    usearch/2.4.0 (test package): CMakeToolchain generated: conan_toolchain.cmake
    usearch/2.4.0 (test package): CMakeToolchain generated: CMakePresets.json
    usearch/2.4.0 (test package): CMakeToolchain generated: ../../../CMakeUserPresets.json
    usearch/2.4.0 (test package): Generating aggregated env files
    usearch/2.4.0 (test package): Generated aggregated env files: ['conanrun.sh', 'conanbuild.sh']
    
    ======== Testing the package: Building ========
    usearch/2.4.0 (test package): Calling build()
    usearch/2.4.0 (test package): Running CMake.configure()
    usearch/2.4.0 (test package): RUN: cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/home/conan/w/prod-v2/bsr/cci-6731bac1/recipes/usearch/all/test_package/build/gcc-11-x86_64-17-release/generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/home/conan/w/prod-v2/bsr/cci-6731bac1/recipes/usearch/all/test_package" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/home/conan/w/prod-v2/bsr/cci-6731bac1/recipes/usearch/all/test_package"
    -- Using Conan toolchain: /home/conan/w/prod-v2/bsr/cci-6731bac1/recipes/usearch/all/test_package/build/gcc-11-x86_64-17-release/generators/conan_toolchain.cmake
    -- Conan toolchain: C++ Standard 17 with extensions OFF
    -- The CXX compiler identification is GNU 11.1.0
    -- Check for working CXX compiler: /usr/local/bin/c++
    -- Check for working CXX compiler: /usr/local/bin/c++ -- works
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- Conan: Target declared 'usearch::usearch'
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /home/conan/w/prod-v2/bsr/cci-6731bac1/recipes/usearch/all/test_package/build/gcc-11-x86_64-17-release
    
    usearch/2.4.0 (test package): Running CMake.build()
    usearch/2.4.0 (test package): RUN: cmake --build "/home/conan/w/prod-v2/bsr/cci-6731bac1/recipes/usearch/all/test_package/build/gcc-11-x86_64-17-release" -- -j3
    Scanning dependencies of target test_package
    [ 50%] Building CXX object CMakeFiles/test_package.dir/test_package.cpp.o
    /home/conan/w/prod-v2/bsr/cci-6731bac1/recipes/usearch/all/test_package/test_package.cpp:1:10: fatal error: usearch/usearch.hpp: No such file or directory
        1 | #include <usearch/usearch.hpp>
          |          ^~~~~~~~~~~~~~~~~~~~~
    compilation terminated.
    CMakeFiles/test_package.dir/build.make:62: recipe for target 'CMakeFiles/test_package.dir/test_package.cpp.o' failed
    make[2]: *** [CMakeFiles/test_package.dir/test_package.cpp.o] Error 1
    CMakeFiles/Makefile2:75: recipe for target 'CMakeFiles/test_package.dir/all' failed
    make[1]: *** [CMakeFiles/test_package.dir/all] Error 2
    Makefile:83: recipe for target 'all' failed
    make: *** [all] Error 2
    
    *********************************************************
    Recipe 'usearch/2.4.0 (test package)' cannot build its binary
    It is possible that this recipe is not Conan 2.0 ready
    If the recipe comes from ConanCenter check: https://conan.io/cci-v2.html
    If it is your recipe, check if it is updated to 2.0
    *********************************************************
    
    ERROR: usearch/2.4.0 (test package): Error in build() method, line 21
    	cmake.build()
    	ConanException: Error 2 while executing
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@ashvardanian
Copy link
Author

Hey @RubenRBS! Can you please help me understand what's wrong with this recipe? Any help you need from me to merge this?

@@ -0,0 +1,24 @@
#include <usearch/usearch.hpp>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashvardanian Here you are including <usearch/usearch.hpp>, but here you copied only index.hpp. The usearch is under c/ folder, but is part of the library usearch_c.

So it's a bit confusing here, you are packing a header-only project, but including a library for testing package 🤔

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uilianries, oh, this is an artifact of our much older attempt. The usearch/index.hpp should be included.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us know once the recipe changes are finished os we can re-review :)

license = "Apache-2.0"
description = "Smaller & Faster Single-File Vector Search Engine from Unum"
homepage = "https://github.com/unum-cloud/usearch"
topics = ("search", "vector", "simd")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
topics = ("search", "vector", "simd")
topics = ("search", "vector", "simd", "header-only")

@valgur valgur mentioned this pull request Feb 28, 2024
@ghost
Copy link

ghost commented Feb 28, 2024

I detected other pull requests that are modifying usearch/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 30, 2024
Copy link
Contributor

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@github-actions github-actions bot closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants