Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql-connector-cpp:8.3.0 #17594

Closed
wants to merge 78 commits into from
Closed

mysql-connector-cpp:8.3.0 #17594

wants to merge 78 commits into from

Conversation

samuaz
Copy link

@samuaz samuaz commented May 17, 2023

Specify library name and version: mysql-connector-cpp/8.0.33

Hi guys, this is to include conan support for mysql-connector-cpp, conan already have the mysql-connector-c but is missing the cpp ones.


@CLAassistant
Copy link

CLAassistant commented May 17, 2023

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@samuaz samuaz changed the title libmysqlcppconn:8.0.33 mysql-connector-cpp:8.0.33 May 17, 2023
@samuaz
Copy link
Author

samuaz commented May 17, 2023

I detected other pull requests that are modifying mysql-connector-cpp/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

oooh!! sorry i dont see it before, what i should do? cancel this?

but looks like that other PR is a bit out of date?

@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

oooh!! sorry i dont see it before, what i should do? cancel this?

We can work on merging both PRs into one that has all the improvements by you both :)

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution, I have added some comments regarding the code.

As for the duplicated PR, it would be great if you could cherry-pick the useful comments from the other PR so their work is properly attributed :)

recipes/mysql-connector-cpp/all/conanfile.py Outdated Show resolved Hide resolved
recipes/mysql-connector-cpp/all/conanfile.py Show resolved Hide resolved
recipes/mysql-connector-cpp/all/conanfile.py Outdated Show resolved Hide resolved
recipes/mysql-connector-cpp/all/conanfile.py Outdated Show resolved Hide resolved
@samuaz
Copy link
Author

samuaz commented May 17, 2023

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 11, 2024
@conan-center-bot

This comment has been minimized.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 20, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 14, 2024
@samuaz
Copy link
Author

samuaz commented Aug 1, 2024

i will update this but seriously guys i fix this many times and never get the approvals

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 8 (86a5df414ef1d8ed25cd61b9a80f762e81db8ebe):

  • mysql-connector-cpp/8.3.0:
    CI failed to create some packages (All logs)

    Logs for packageID 9af53cd7d6e7c4d2eed9c91d1914010636c4d9ed:
    [settings]
    arch=armv8
    build_type=Debug
    compiler=apple-clang
    compiler.libcxx=libc++
    compiler.version=13.0
    os=Macos
    [options]
    mysql-connector-cpp:shared=False
    
    [...]
        /Users/jenkins/workspace/prod-v1/bsr/76519/cfdfd/.conan/data/mysql-connector-cpp/8.3.0/_/_/package/9af53cd7d6e7c4d2eed9c91d1914010636c4d9ed/lib/debug/libmysqlcppconn-static.a(libcrypto-lib-eng_lib.o)
        /Users/jenkins/workspace/prod-v1/bsr/76519/cfdfd/.conan/data/openssl/3.2.2/_/_/package/ff757993f715b5a535f74d927613dec74a6163f6/lib/libcrypto.a(libcrypto-lib-eng_lib.o)
    duplicate symbol '_ENGINE_get_static_state' in:
        /Users/jenkins/workspace/prod-v1/bsr/76519/cfdfd/.conan/data/mysql-connector-cpp/8.3.0/_/_/package/9af53cd7d6e7c4d2eed9c91d1914010636c4d9ed/lib/debug/libmysqlcppconn-static.a(libcrypto-lib-eng_lib.o)
        /Users/jenkins/workspace/prod-v1/bsr/76519/cfdfd/.conan/data/openssl/3.2.2/_/_/package/ff757993f715b5a535f74d927613dec74a6163f6/lib/libcrypto.a(libcrypto-lib-eng_lib.o)
    duplicate symbol '_ENGINE_set_name' in:
        /Users/jenkins/workspace/prod-v1/bsr/76519/cfdfd/.conan/data/mysql-connector-cpp/8.3.0/_/_/package/9af53cd7d6e7c4d2eed9c91d1914010636c4d9ed/lib/debug/libmysqlcppconn-static.a(libcrypto-lib-eng_lib.o)
        /Users/jenkins/workspace/prod-v1/bsr/76519/cfdfd/.conan/data/openssl/3.2.2/_/_/package/ff757993f715b5a535f74d927613dec74a6163f6/lib/libcrypto.a(libcrypto-lib-eng_lib.o)
    duplicate symbol '_ENGINE_get_name' in:
        /Users/jenkins/workspace/prod-v1/bsr/76519/cfdfd/.conan/data/mysql-connector-cpp/8.3.0/_/_/package/9af53cd7d6e7c4d2eed9c91d1914010636c4d9ed/lib/debug/libmysqlcppconn-static.a(libcrypto-lib-eng_lib.o)
        /Users/jenkins/workspace/prod-v1/bsr/76519/cfdfd/.conan/data/openssl/3.2.2/_/_/package/ff757993f715b5a535f74d927613dec74a6163f6/lib/libcrypto.a(libcrypto-lib-eng_lib.o)
    duplicate symbol '_ENGINE_free' in:
        /Users/jenkins/workspace/prod-v1/bsr/76519/cfdfd/.conan/data/mysql-connector-cpp/8.3.0/_/_/package/9af53cd7d6e7c4d2eed9c91d1914010636c4d9ed/lib/debug/libmysqlcppconn-static.a(libcrypto-lib-eng_lib.o)
        /Users/jenkins/workspace/prod-v1/bsr/76519/cfdfd/.conan/data/openssl/3.2.2/_/_/package/ff757993f715b5a535f74d927613dec74a6163f6/lib/libcrypto.a(libcrypto-lib-eng_lib.o)
    duplicate symbol '_ENGINE_set_id' in:
        /Users/jenkins/workspace/prod-v1/bsr/76519/cfdfd/.conan/data/mysql-connector-cpp/8.3.0/_/_/package/9af53cd7d6e7c4d2eed9c91d1914010636c4d9ed/lib/debug/libmysqlcppconn-static.a(libcrypto-lib-eng_lib.o)
        /Users/jenkins/workspace/prod-v1/bsr/76519/cfdfd/.conan/data/openssl/3.2.2/_/_/package/ff757993f715b5a535f74d927613dec74a6163f6/lib/libcrypto.a(libcrypto-lib-eng_lib.o)
    duplicate symbol '_ENGINE_get_id' in:
        /Users/jenkins/workspace/prod-v1/bsr/76519/cfdfd/.conan/data/mysql-connector-cpp/8.3.0/_/_/package/9af53cd7d6e7c4d2eed9c91d1914010636c4d9ed/lib/debug/libmysqlcppconn-static.a(libcrypto-lib-eng_lib.o)
        /Users/jenkins/workspace/prod-v1/bsr/76519/cfdfd/.conan/data/openssl/3.2.2/_/_/package/ff757993f715b5a535f74d927613dec74a6163f6/lib/libcrypto.a(libcrypto-lib-eng_lib.o)
    duplicate symbol '_ENGINE_set_ex_data' in:
        /Users/jenkins/workspace/prod-v1/bsr/76519/cfdfd/.conan/data/mysql-connector-cpp/8.3.0/_/_/package/9af53cd7d6e7c4d2eed9c91d1914010636c4d9ed/lib/debug/libmysqlcppconn-static.a(libcrypto-lib-eng_lib.o)
        /Users/jenkins/workspace/prod-v1/bsr/76519/cfdfd/.conan/data/openssl/3.2.2/_/_/package/ff757993f715b5a535f74d927613dec74a6163f6/lib/libcrypto.a(libcrypto-lib-eng_lib.o)
    duplicate symbol '_ENGINE_get_ex_data' in:
        /Users/jenkins/workspace/prod-v1/bsr/76519/cfdfd/.conan/data/mysql-connector-cpp/8.3.0/_/_/package/9af53cd7d6e7c4d2eed9c91d1914010636c4d9ed/lib/debug/libmysqlcppconn-static.a(libcrypto-lib-eng_lib.o)
        /Users/jenkins/workspace/prod-v1/bsr/76519/cfdfd/.conan/data/openssl/3.2.2/_/_/package/ff757993f715b5a535f74d927613dec74a6163f6/lib/libcrypto.a(libcrypto-lib-eng_lib.o)
    duplicate symbol '_do_engine_lock_init_ossl_ret_' in:
        /Users/jenkins/workspace/prod-v1/bsr/76519/cfdfd/.conan/data/mysql-connector-cpp/8.3.0/_/_/package/9af53cd7d6e7c4d2eed9c91d1914010636c4d9ed/lib/debug/libmysqlcppconn-static.a(libcrypto-lib-eng_lib.o)
        /Users/jenkins/workspace/prod-v1/bsr/76519/cfdfd/.conan/data/openssl/3.2.2/_/_/package/ff757993f715b5a535f74d927613dec74a6163f6/lib/libcrypto.a(libcrypto-lib-eng_lib.o)
    duplicate symbol '_do_engine_lock_init_ossl_' in:
        /Users/jenkins/workspace/prod-v1/bsr/76519/cfdfd/.conan/data/mysql-connector-cpp/8.3.0/_/_/package/9af53cd7d6e7c4d2eed9c91d1914010636c4d9ed/lib/debug/libmysqlcppconn-static.a(libcrypto-lib-eng_lib.o)
        /Users/jenkins/workspace/prod-v1/bsr/76519/cfdfd/.conan/data/openssl/3.2.2/_/_/package/ff757993f715b5a535f74d927613dec74a6163f6/lib/libcrypto.a(libcrypto-lib-eng_lib.o)
    ld: 29 duplicate symbols for architecture arm64
    clang: error: linker command failed with exit code 1 (use -v to see invocation)
    make[2]: *** [test_package] Error 1
    make[1]: *** [CMakeFiles/test_package.dir/all] Error 2
    make: *** [all] Error 2
    WARN: *** Conan 1 is legacy and on a deprecation path ***
    WARN: *** Please upgrade to Conan 2 ***
    WARN: protobuf/3.21.12: requirement zlib/[>=1.2.11 <2] overridden by mysql-connector-cpp/8.3.0 to zlib/1.3.1 
    WARN: boost/1.84.0: requirement zlib/[>=1.2.11 <2] overridden by mysql-connector-cpp/8.3.0 to zlib/1.3.1 
    WARN: openssl/3.2.2: requirement zlib/[>=1.2.11 <2] overridden by mysql-connector-cpp/8.3.0 to zlib/1.3.1 
    WARN: libmysqlclient/8.1.0: requirement openssl/[>=1.1 <4] overridden by mysql-connector-cpp/8.3.0 to openssl/3.2.2 
    WARN: libmysqlclient/8.1.0: requirement zlib/[>=1.2.11 <2] overridden by mysql-connector-cpp/8.3.0 to zlib/1.3.1 
    mysql-connector-cpp/8.3.0: WARN: Lib folder doesn't exist, can't collect libraries: /Users/jenkins/workspace/prod-v1/bsr/76519/cfdfd/.conan/data/mysql-connector-cpp/8.3.0/_/_/package/9af53cd7d6e7c4d2eed9c91d1914010636c4d9ed/lib64/debug
    mysql-connector-cpp/8.3.0 (test package): WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    mysql-connector-cpp/8.3.0 (test package): WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    ERROR: mysql-connector-cpp/8.3.0 (test package): Error in build() method, line 26
    	cmake.build()
    	ConanException: Error 2 while executing cmake --build "/Users/jenkins/workspace/prod-v1/bsr/cci-ff5a57d4/recipes/mysql-connector-cpp/all/test_package/build/Debug" '--' '-j8'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 8 (86a5df414ef1d8ed25cd61b9a80f762e81db8ebe):

  • mysql-connector-cpp/8.3.0:
    CI failed to create some packages (All logs)

    Logs for packageID ca64ea5c5e80aceab6090aa68593145da9937d8f:
    [settings]
    arch=armv8
    build_type=Release
    compiler=apple-clang
    compiler.cppstd=17
    compiler.libcxx=libc++
    compiler.version=13
    os=Macos
    [options]
    */*:shared=False
    
    [...]
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/b/mysql074628816f79d/p/lib/libmysqlcppconn-static.a(libcrypto-lib-eng_lib.o)
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/opensb4c37c1418d63/p/lib/libcrypto.a(libcrypto-lib-eng_lib.o)
    duplicate symbol '_ENGINE_get_finish_function' in:
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/b/mysql074628816f79d/p/lib/libmysqlcppconn-static.a(libcrypto-lib-eng_lib.o)
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/opensb4c37c1418d63/p/lib/libcrypto.a(libcrypto-lib-eng_lib.o)
    duplicate symbol '_engine_set_all_null' in:
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/b/mysql074628816f79d/p/lib/libmysqlcppconn-static.a(libcrypto-lib-eng_lib.o)
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/opensb4c37c1418d63/p/lib/libcrypto.a(libcrypto-lib-eng_lib.o)
    duplicate symbol '_engine_free_util' in:
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/b/mysql074628816f79d/p/lib/libmysqlcppconn-static.a(libcrypto-lib-eng_lib.o)
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/opensb4c37c1418d63/p/lib/libcrypto.a(libcrypto-lib-eng_lib.o)
    duplicate symbol '_ENGINE_get_static_state' in:
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/b/mysql074628816f79d/p/lib/libmysqlcppconn-static.a(libcrypto-lib-eng_lib.o)
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/opensb4c37c1418d63/p/lib/libcrypto.a(libcrypto-lib-eng_lib.o)
    duplicate symbol '_ENGINE_set_name' in:
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/b/mysql074628816f79d/p/lib/libmysqlcppconn-static.a(libcrypto-lib-eng_lib.o)
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/opensb4c37c1418d63/p/lib/libcrypto.a(libcrypto-lib-eng_lib.o)
    duplicate symbol '_ENGINE_get_name' in:
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/b/mysql074628816f79d/p/lib/libmysqlcppconn-static.a(libcrypto-lib-eng_lib.o)
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/opensb4c37c1418d63/p/lib/libcrypto.a(libcrypto-lib-eng_lib.o)
    duplicate symbol '_ENGINE_free' in:
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/b/mysql074628816f79d/p/lib/libmysqlcppconn-static.a(libcrypto-lib-eng_lib.o)
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/opensb4c37c1418d63/p/lib/libcrypto.a(libcrypto-lib-eng_lib.o)
    duplicate symbol '_ENGINE_set_id' in:
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/b/mysql074628816f79d/p/lib/libmysqlcppconn-static.a(libcrypto-lib-eng_lib.o)
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/opensb4c37c1418d63/p/lib/libcrypto.a(libcrypto-lib-eng_lib.o)
    duplicate symbol '_ENGINE_get_id' in:
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/b/mysql074628816f79d/p/lib/libmysqlcppconn-static.a(libcrypto-lib-eng_lib.o)
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/opensb4c37c1418d63/p/lib/libcrypto.a(libcrypto-lib-eng_lib.o)
    duplicate symbol '_ENGINE_set_ex_data' in:
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/b/mysql074628816f79d/p/lib/libmysqlcppconn-static.a(libcrypto-lib-eng_lib.o)
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/opensb4c37c1418d63/p/lib/libcrypto.a(libcrypto-lib-eng_lib.o)
    duplicate symbol '_ENGINE_get_ex_data' in:
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/b/mysql074628816f79d/p/lib/libmysqlcppconn-static.a(libcrypto-lib-eng_lib.o)
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/opensb4c37c1418d63/p/lib/libcrypto.a(libcrypto-lib-eng_lib.o)
    duplicate symbol '_do_engine_lock_init_ossl_ret_' in:
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/b/mysql074628816f79d/p/lib/libmysqlcppconn-static.a(libcrypto-lib-eng_lib.o)
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/opensb4c37c1418d63/p/lib/libcrypto.a(libcrypto-lib-eng_lib.o)
    duplicate symbol '_do_engine_lock_init_ossl_' in:
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/b/mysql074628816f79d/p/lib/libmysqlcppconn-static.a(libcrypto-lib-eng_lib.o)
        /Users/jenkins/workspace/prod-v2/bsr/69137/dccaa/p/opensb4c37c1418d63/p/lib/libcrypto.a(libcrypto-lib-eng_lib.o)
    ld: 58 duplicate symbols for architecture arm64
    clang: error: linker command failed with exit code 1 (use -v to see invocation)
    make[2]: *** [test_package] Error 1
    make[1]: *** [CMakeFiles/test_package.dir/all] Error 2
    make: *** [all] Error 2
    
    ERROR: mysql-connector-cpp/8.3.0 (test package): Error in build() method, line 26
    	cmake.build()
    	ConanException: Error 2 while executing
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@rasikhq
Copy link

rasikhq commented Aug 15, 2024

i will update this but seriously guys i fix this many times and never get the approvals

Thanks @samuaz for your effort, I am really looking forward to this recipe getting added. I've tried multiple alternatives but those didn't work out.

@perseoGI perseoGI mentioned this pull request Sep 5, 2024
3 tasks
@perseoGI
Copy link
Contributor

perseoGI commented Sep 5, 2024

Hi @samuaz 👋
As there is already some work on introducing mysql-connector-cpp in CCI, let's focus the efforts on a single PR.
In this case, we have decided to make it this one #24678
So lets work together there!
Thanks in advance 🐸

@perseoGI perseoGI closed this Sep 5, 2024
@samuaz
Copy link
Author

samuaz commented Nov 21, 2024

Hi @samuaz 👋 As there is already some work on introducing mysql-connector-cpp in CCI, let's focus the efforts on a single PR. In this case, we have decided to make it this one #24678 So lets work together there! Thanks in advance 🐸

@perseoGI the other PR is not supporting JDBC connector, so why you prefer that instead of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants