Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add swig/4.0.1 #1717
Add swig/4.0.1 #1717
Changes from 6 commits
0684041
e34d0b1
409b5d9
07e642b
2a0364b
84ad511
1e43ca8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very interesting ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this recipe needs the same treatment as cmake: #1783
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this
<PKG-NAME>_EXECUTABLE
something standard in CMake? What happens if the sources provide more than one executable? Asking this just to know if it makes sense to add this as a feature in the CMake generatorsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I's quite common:
SWIG_EXECUTABLE
: https://cmake.org/cmake/help/latest/module/FindSWIG.htmlPYTHON_EXECUTABLE
: https://cmake.org/cmake/help/latest/module/FindPythonInterp.htmlDOXYGEN_EXECUTABLE
: https://cmake.org/cmake/help/latest/module/FindDoxygen.htmlPERL_EXECUTABLE
: https://cmake.org/cmake/help/latest/module/FindPerl.htmlWGET_EXECUTABLE
: https://cmake.org/cmake/help/latest/module/FindWget.htmlAlso, some provide more than one _EXECUTABLE variable:
Java_JAVA_EXECUTABLE
Java_JAVAC_EXECUTABLE
Java_JAVAH_EXECUTABLE
... https://cmake.org/cmake/help/latest/module/FindJava.htmlBut there are exceptions:
HTML_HELP_COMPILER
: https://cmake.org/cmake/help/latest/module/FindHTMLHelp.htmlAlso, it would be interesting to provide these as targets:
Doxygen::Doxygen
Doxygen::dot
Doxygen::mscgen
Doxygen::dia
: https://cmake.org/cmake/help/latest/module/FindDoxygen.htmlIt is stated there that the
_EXECUTABLE
variables are getting deprecated.(but conan should provide these for the sake of compatibility)