-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onnxruntime: add 1.14.1 #16849
onnxruntime: add 1.14.1 #16849
Conversation
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 183c477onnxruntime/1.14.1
|
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 183c477onnxruntime/1.14.1
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
c536e10
to
af414de
Compare
This comment has been minimized.
This comment has been minimized.
af414de
to
ac46bba
Compare
This comment has been minimized.
This comment has been minimized.
ac46bba
to
a95ceed
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW if you don't have time to iterate over this recipe i'm able to help during this week.
waiting #16701 to be merged @prince-chrismc fyi |
a95ceed
to
903c5a7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
39e4a55
to
e2e663f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 640b652onnxruntime/1.14.1
|
Tried building with this command
And the build succeeds... so either it affects only apple-clang 13, or it's a c3i issue. Conan2 builds are optional anyways no? For me I would merge it already. |
This comment has been minimized.
This comment has been minimized.
conan v2 now fails with something different... unrelated to the change. |
This comment has been minimized.
This comment has been minimized.
Conan v2 failure just means @prince-chrismc last MR for date recipe generated v2 packages #16709 (comment) https://github.com/conan-io/conan-center-index/commits/master/recipes/date/all/conanfile.py why aren't they available now? |
@Hopobcn, I do understand that but builds weren't failing for Linux on conan v2 before. e.g. in build 21, which was passing for that configuration, we get:
& in build 23/24, the same config is not passing with:
@prince-chrismc, |
This comment has been minimized.
This comment has been minimized.
closing/reopening to see if #17163 helped with conan v2 |
This comment has been minimized.
This comment has been minimized.
It did, yeah |
v2 is missing 🤔 |
I don't why it did not appear in the PR but it was built on c3i: https://c3i.jfrog.io/c3i/misc-v2/logs/pr/16849/25/onnxruntime/1.14.1/summary.json |
Conan v1 pipeline ✔️All green in build 26 (
Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 26 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Thanks for this! Huge help to have ORT on conan. I was able to successfully build, link to, and test ORT but I get the same warnings at runtime as microsoft/onnxruntime#8556: I'm guessing it has something to do with |
* onnxruntime * Fix hook reported error * Fix TypeError: unhashable type: 'SettingsItem' * don't link with boost * fix linter issue on test_package * drop cmake_new_enough
Specify library name and version: onnxruntime/1.14.1
Fixes #4806
Fixes #16699
Closes #16842
This is similar to #16842 but I already had some work done before that PR was created and thought I'd share the state of said work.
Differences with #16842:
mac armv8 will fail because eigen 3.4.0 has a bug (onnxruntime pins a git commit before 3.4.0, the not released 3.4.1 has a fix for this), c.f. eigen(3.4.0): Fix vectorized reductions compilation errors for Eigen::half #16854Windows will most likely fail (pending wil: recipe added #16701 & update of the requirement/patch)no options are implemented yet.onlywith_xnnpack
option is implemented.It's been built and tested on mac arm64 & linux x86_64 (gcc-12).
Unit tests were built with a specific patch (adding the missing onyx proto & patching tests for the location) & run successfully.
conan v2 won't build without #16703 EDIT: now availableI also opened microsoft/onnxruntime#15323 upstream to get some sense of what part of the patch could be upstreamed.EDIT the PR was merged in onnxruntime/main for a future version, I'll try to see if I can squeeze other changes as well.Like @gmeeker in #16842, I don't really have time to finish this recipe (and in my case, I don't have the skills to do so), so any help is appreciated.