Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nas: use newer user conf from xorg-cf-files dependency #16267

Merged
merged 2 commits into from
Mar 15, 2023
Merged

nas: use newer user conf from xorg-cf-files dependency #16267

merged 2 commits into from
Mar 15, 2023

Conversation

jcar87
Copy link
Contributor

@jcar87 jcar87 commented Feb 24, 2023

Specify library name and version: nas/all

  • Use new from from recently updated xorg-cf-files
  • Use imake in buildenv environment

@github-actions github-actions bot mentioned this pull request Feb 24, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
StellaSmith
StellaSmith previously approved these changes Feb 27, 2023
View reviewed changes
@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Mar 9, 2023
Closed
Merged
@ghost
Copy link

ghost commented Mar 9, 2023

I detected other pull requests that are modifying nas/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@jcar87 jcar87 force-pushed the lcc/maintenance/libmysqlclient-openssl-bump branch from 0682b41 to a82242b Compare March 14, 2023 11:01
@conan-center-bot

This comment has been minimized.

Sign in to view
@jcar87
Copy link
Contributor Author

jcar87 commented Mar 15, 2023 •
edited
Loading

After some investigation, this recipe cannot be built with the compiler is clang, if gcc is not installed on the system. The imake invocation requires gcc to act as the pre-processor. While we could use the IMAKECPP to point to clang, clang does not behave the same as gcc and the build fails.

A similar issue was experienced by the gentoo maintainers: https://bugs.gentoo.org/729526, where the only solution is for gcc to be available at least at build time. The actual binary code can (presumably) still be compiled with clang - but gcc would need to be installed in the system and the recipe amended to support this.

It should be noted that nas uses imake as part of its build process, but imake itself has not been fully maitained nor supported since Xorg stopped using it around 2005, and imake itself is self-described as "obsolete". I would not expect compatibility with clang anytime soon.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (805871419bc13cfc06e1fdd941652221781db2ad):

  • nas/1.9.5@:
    All packages built successfully! (All logs)

  • nas/1.9.4@:
    All packages built successfully! (All logs)

Conan v2 pipeline (informative, not required for merge) ✔️

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

All green in build 4 (805871419bc13cfc06e1fdd941652221781db2ad):

  • nas/1.9.5@:
    All packages built successfully! (All logs)

  • nas/1.9.4@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit c0edbe3 into conan-io:master Mar 15, 2023
@jcar87 jcar87 deleted the lcc/maintenance/libmysqlclient-openssl-bump branch March 15, 2023 14:03
@StellaSmith StellaSmith mentioned this pull request Mar 18, 2023
Open
dariusarnold added a commit to dariusarnold/game-boy-emulator that referenced this pull request Apr 2, 2023
@dariusarnold
Remove nas dependency
4fbd254 
Due to a recent change, the nas recipe is incompatible with clang
(conan-io/conan-center-index#16267 (comment)).
Locally I had the previous version in the cache, but it failed on CI. Since I
dont use nas (it came as a dependency of SDL), configure the dependency away to
be able to build with clang.
0xFireWolf pushed a commit to 0xFireWolf/conan-center-index that referenced this pull request Apr 2, 2023
@jcar87 @0xFireWolf
(conan-io#16267) nas: use newer user conf from xorg-cf-files dependency
0b1b455 
* nas: use newer user conf from xorg-cf-files dependency

* nas: raise invalid configuration when clang is compiler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StellaSmith StellaSmith StellaSmith approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcar87 @conan-center-bot @AbrilRBS @StellaSmith