czmq: use official tarball + fix dependencies handling #15670

SpaceIm · 2023-02-02T00:41:20Z

download stable archives
fix CMake patches. I don't know how it was handled before conan v2 migration, but current patches from czmq: add version 4.2.1, support conan v2, add options #15138 are broken (several options are not honored, and files generated by CMakeDeps are not always used).
add with_libmicrohttpd option
properly map enable_drafts recipe option to ENABLE_DRAFTS upstream CMake option.
remove with_libmicrohttpd & with_libcurl options when enable_drafts is disabled (these 2 libs are optional dependencies of compilation units included only when enable_drafts is True).
remove openssl from requirements, nothing depends on OpenSSL in czmq source code despite what the comment claims.
honor fPIC=False
relocatable shared lib on macOS
switch to C test package (czmq is a high level C binding of ZeroMQ after all)
do not export all symbols with msvc, it seems that czmq: add version 4.2.1, support conan v2, add options #15138 has introduced an issue by injecting CZMQ_STATIC = 1 if shared (a mistake while translating the legacy CMakeLists wrapper I guess, by the way this injection was useless anyway for static because upstream CMakeLists handles that already), then tried to solve the consequence of this mistake by exporting all symbols, very weird.

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

conan-center-bot · 2023-02-02T08:39:04Z

Conan v1 pipeline ✔️

All green in build 5 (ba46498fe99c7acbf931a2a5eb3663bd6ee25dda):

czmq/4.2.1@:
All packages built successfully! (All logs)
czmq/4.2.0@:
All packages built successfully! (All logs)

Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 5 (ba46498fe99c7acbf931a2a5eb3663bd6ee25dda):

czmq/4.2.1@:
Error running command conan graph info --requires czmq/4.2.1@#15e5b952b4eafaf107eadf0f4bf84c91 -f json -pr:h /home/conan/w/prod-v2_cci_PR-15670/5/288e8add-f94e-4930-95e8-f24d0adea455/profile_linux_11_libstdcpp11_gcc_release_64.-shared-False.txt -pr:b /home/conan/w/prod-v2_cci_PR-15670/5/288e8add-f94e-4930-95e8-f24d0adea455/profile_linux_11_libstdcpp11_gcc_release_64.-shared-False.txt:

-------- Input profiles --------
Profile host:
[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[options]
*/*:shared=False

Profile build:
[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[options]
*/*:shared=False


-------- Computing dependency graph --------
zeromq/4.3.4: Not found in local cache, looking in remotes...
zeromq/4.3.4: Checking remote: conan-center-v2
zeromq/4.3.4: Trying with 'conan-center-v2'...
Downloading conanfile.py
Downloading conanmanifest.txt
Downloading conan_export.tgz
Decompressing conan_export.tgz
zeromq/4.3.4: Downloaded recipe revision 30554b087a2f3c8117b27787a8a4e0e9
libsodium/1.0.18: Not found in local cache, looking in remotes...
libsodium/1.0.18: Checking remote: conan-center-v2
libsodium/1.0.18: Trying with 'conan-center-v2'...
Downloading conanmanifest.txt
Downloading conanfile.py
Downloading conan_export.tgz
Decompressing conan_export.tgz
libsodium/1.0.18: Downloaded recipe revision 9e310e52ed60084484c5f640ab88883a
lz4/1.9.4: Not found in local cache, looking in remotes...
lz4/1.9.4: Checking remote: conan-center-v2
lz4/1.9.4: Trying with 'conan-center-v2'...
Downloading conanmanifest.txt
Downloading conanfile.py
Downloading conan_export.tgz
Decompressing conan_export.tgz
lz4/1.9.4: Downloaded recipe revision bce1f314775b83c195dffc8e177ff368
libuuid/1.0.3: Not found in local cache, looking in remotes...
libuuid/1.0.3: Checking remote: conan-center-v2
libuuid/1.0.3: Trying with 'conan-center-v2'...
Downloading conanmanifest.txt
Downloading conanfile.py
Downloading conan_export.tgz
Decompressing conan_export.tgz
libuuid/1.0.3: Downloaded recipe revision 3e9be5bc8c9cc5fe341262bfb8fba195
libtool/2.4.7: Not found in local cache, looking in remotes...
libtool/2.4.7: Checking remote: conan-center-v2
Graph root
    virtual
Requirements
    czmq/4.2.1#15e5b952b4eafaf107eadf0f4bf84c91 - Cache
    libsodium/1.0.18#9e310e52ed60084484c5f640ab88883a - Downloaded (conan-center-v2)
    libuuid/1.0.3#3e9be5bc8c9cc5fe341262bfb8fba195 - Downloaded (conan-center-v2)
    lz4/1.9.4#bce1f314775b83c195dffc8e177ff368 - Downloaded (conan-center-v2)
    zeromq/4.3.4#30554b087a2f3c8117b27787a8a4e0e9 - Downloaded (conan-center-v2)
Graph error
    Package 'libtool/2.4.7' not resolved: Unable to find 'libtool/2.4.7' in remotes
ERROR: Package 'libtool/2.4.7' not resolved: Unable to find 'libtool/2.4.7' in remotes

czmq/4.2.0@:
Error running command conan graph info --requires czmq/4.2.0@#6afe1156c478f7f3bf5cd11cb5a083ee -f json -pr:h /home/conan/w/prod-v2_cci_PR-15670/5/3f41881e-a7a8-4601-aa28-341d2390d67b/profile_linux_11_libstdcpp11_gcc_release_64.-shared-False.txt -pr:b /home/conan/w/prod-v2_cci_PR-15670/5/3f41881e-a7a8-4601-aa28-341d2390d67b/profile_linux_11_libstdcpp11_gcc_release_64.-shared-False.txt:

-------- Input profiles --------
Profile host:
[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[options]
*/*:shared=False

Profile build:
[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[options]
*/*:shared=False


-------- Computing dependency graph --------
zeromq/4.3.4: Not found in local cache, looking in remotes...
zeromq/4.3.4: Checking remote: conan-center-v2
zeromq/4.3.4: Trying with 'conan-center-v2'...
Downloading conanmanifest.txt
Downloading conanfile.py
Downloading conan_export.tgz
Decompressing conan_export.tgz
zeromq/4.3.4: Downloaded recipe revision 30554b087a2f3c8117b27787a8a4e0e9
libsodium/1.0.18: Not found in local cache, looking in remotes...
libsodium/1.0.18: Checking remote: conan-center-v2
libsodium/1.0.18: Trying with 'conan-center-v2'...
Downloading conanmanifest.txt
Downloading conanfile.py
Downloading conan_export.tgz
Decompressing conan_export.tgz
libsodium/1.0.18: Downloaded recipe revision 9e310e52ed60084484c5f640ab88883a
lz4/1.9.4: Not found in local cache, looking in remotes...
lz4/1.9.4: Checking remote: conan-center-v2
lz4/1.9.4: Trying with 'conan-center-v2'...
Downloading conanmanifest.txt
Downloading conan_export.tgz
Downloading conanfile.py
Decompressing conan_export.tgz
lz4/1.9.4: Downloaded recipe revision bce1f314775b83c195dffc8e177ff368
libuuid/1.0.3: Not found in local cache, looking in remotes...
libuuid/1.0.3: Checking remote: conan-center-v2
libuuid/1.0.3: Trying with 'conan-center-v2'...
Downloading conanmanifest.txt
Downloading conanfile.py
Downloading conan_export.tgz
Decompressing conan_export.tgz
libuuid/1.0.3: Downloaded recipe revision 3e9be5bc8c9cc5fe341262bfb8fba195
libtool/2.4.7: Not found in local cache, looking in remotes...
libtool/2.4.7: Checking remote: conan-center-v2
Graph root
    virtual
Requirements
    czmq/4.2.0#6afe1156c478f7f3bf5cd11cb5a083ee - Cache
    libsodium/1.0.18#9e310e52ed60084484c5f640ab88883a - Downloaded (conan-center-v2)
    libuuid/1.0.3#3e9be5bc8c9cc5fe341262bfb8fba195 - Downloaded (conan-center-v2)
    lz4/1.9.4#bce1f314775b83c195dffc8e177ff368 - Downloaded (conan-center-v2)
    zeromq/4.3.4#30554b087a2f3c8117b27787a8a4e0e9 - Downloaded (conan-center-v2)
Graph error
    Package 'libtool/2.4.7' not resolved: Unable to find 'libtool/2.4.7' in remotes
ERROR: Package 'libtool/2.4.7' not resolved: Unable to find 'libtool/2.4.7' in remotes

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

* download official tarballs * modernize more * relocatable shared lib on macOS * fix discovery of dependencies and options logic * remove openssl from requirements * switch to C test package since czmq is C binding of ZeroMQ after all * do not export all symbols * with_libmicrohttpd option instead of with_microhttpd

SpaceIm added 5 commits February 2, 2023 00:25

download official tarballs

a785399

modernize more

a1a73d7

relocatable shared lib on macOS

99d7686

fix discovery of dependencies and options logic

bdac572

remove openssl from requirements

8ce637c

github-actions bot mentioned this pull request Feb 2, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

SpaceIm added 2 commits February 2, 2023 02:08

switch to C test package since czmq is C binding of ZeroMQ after all

a476ea4

do not export all symbols

6d496d4

This comment has been minimized.

Sign in to view

with_libmicrohttpd option instead of with_microhttpd

ba46498

jwillikers approved these changes Feb 2, 2023

View reviewed changes

prince-chrismc mentioned this pull request Feb 2, 2023

Rank effort to review a given PR prince-chrismc/conan-center-index-pending-review#109

Merged

1 task

conan-center-bot requested a review from franramirez688 February 8, 2023 12:01

prince-chrismc added the checksum_mismatch label Feb 12, 2023

prince-chrismc approved these changes Feb 12, 2023

View reviewed changes

conan-center-bot merged commit 506b6d9 into conan-io:master Feb 12, 2023

SpaceIm deleted the czmq-official-tarball branch February 12, 2023 09:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

czmq: use official tarball + fix dependencies handling #15670

czmq: use official tarball + fix dependencies handling #15670

SpaceIm commented Feb 2, 2023 •

edited

Loading

This comment has been minimized.

conan-center-bot commented Feb 2, 2023

czmq: use official tarball + fix dependencies handling #15670

czmq: use official tarball + fix dependencies handling #15670

Conversation

SpaceIm commented Feb 2, 2023 • edited Loading

This comment has been minimized.

conan-center-bot commented Feb 2, 2023

Conan v1 pipeline ✔️

Conan v2 pipeline (informative, not required for merge) ❌

SpaceIm commented Feb 2, 2023 •

edited

Loading