Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kcov] Bump version release 40 #11233

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

EstebanDugueperoux2
Copy link
Contributor

@EstebanDugueperoux2 EstebanDugueperoux2 commented Jun 16, 2022

Specify library name and version: kcov/40

closes #11231

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@CLAassistant
Copy link

CLAassistant commented Jun 16, 2022

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@uilianries uilianries changed the title [#11231] Provides kcov release 40 [kcov] Bump version release 40 Jun 17, 2022
@conan-center-bot

This comment has been minimized.

uilianries
uilianries previously approved these changes Jun 17, 2022
@EstebanDugueperoux2
Copy link
Contributor Author

Hi @uilianries,

I'm waiting access to https://ci-conan-prod.jfrog.team/job/prod/job/cci/job/PR-11233/4/display/redirect to fix failures.

Thanks in advance.

@conan-center-bot

This comment has been minimized.

@EstebanDugueperoux2 EstebanDugueperoux2 marked this pull request as ready for review June 17, 2022 07:54
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@EstebanDugueperoux2
Copy link
Contributor Author

@jgsogo I try to build kcov here but get "Missing prebuilt package for 'libcurl/7.64.1'"
Could you help me on this?
How to specify "--build missing" in Github actions?

Regards.

@EstebanDugueperoux2
Copy link
Contributor Author

@uilianries
Now I get following error:

ERROR: [INCLUDE PATH DOES NOT EXIST (KB-H071)] Component kcov::kcov include dir 'include' is listed in the recipe, but not found in package folder. The include dir should probably be fixed or removed. (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H071)

See https://c3i.jfrog.io/c3i/misc/logs/pr/11233/9-linux-gcc/kcov/38//6a45c4b56e1770d80b4de07b3c126918157675a8-build.txt

The hook KB-H071 is not documented, i.e. https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H071 is a bad link.
In additition I have not include declaration in the recipe.

Could you help me to diagnostic this issue?

Regards.

@conan-center-bot

This comment has been minimized.

@EstebanDugueperoux2
Copy link
Contributor Author

I have just rebased but get randomly same error on kcov/38@ or kcov/40@.

@jgsogo
Copy link
Contributor

jgsogo commented Jun 28, 2022

The error from the hooks should be self-explanatory:

[HOOK - conan-center.py] post_package_info(): ERROR: [INCLUDE PATH DOES NOT EXIST (KB-H071)] Component kcov::kcov include dir 'include' is listed in the recipe, but not found in package folder. The include dir should probably be fixed or removed. (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H071)

If this package doesn´t provide anything in the include folder, you need to assign an empty list:

def package_info(self):
   ...
   self.cpp_info.includedirs = []

@conan-center-bot

This comment has been minimized.

@EstebanDugueperoux2
Copy link
Contributor Author

The error from the hooks should be self-explanatory:

[HOOK - conan-center.py] post_package_info(): ERROR: [INCLUDE PATH DOES NOT EXIST (KB-H071)] Component kcov::kcov include dir 'include' is listed in the recipe, but not found in package folder. The include dir should probably be fixed or removed. (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H071)

If this package doesn´t provide anything in the include folder, you need to assign an empty list:

def package_info(self):
   ...
   self.cpp_info.includedirs = []

Ok thanks, sorry but I'm beginner in all of that (conan, C++, ...).
I understand that by default self.cpp_info.includedirs as "include" default value.

Regards.

@conan-center-bot

This comment has been minimized.

@jgsogo
Copy link
Contributor

jgsogo commented Jun 29, 2022

The error is self-explanatory, but the entry is not added to the KB, so the link is basically broken 🤦 , sorry about that (cc/ @uilianries )

@uilianries
Copy link
Member

Sorry, indeed we need to re-check hooks vs docs, because, from time to time, we update/fix and forget to update the documentation.

@EstebanDugueperoux2
Copy link
Contributor Author

Sorry, indeed we need to re-check hooks vs docs, because, from time to time, we update/fix and forget to update the documentation.

And what about "Error: open .c3i/c3i.yml: no such file or directory" error in https://github.com/conan-io/conan-center-index/runs/7100007371?check_suite_focus=true ?

@uilianries
Copy link
Member

And what about "Error: open .c3i/c3i.yml: no such file or directory" error in conan-io/conan-center-index/runs/7100007371?check_suite_focus=true ?

This was a bug, not a misinformation. It's fixed now.

@conan-center-bot
Copy link
Collaborator

All green in build 15 (d14a1ee8bf2722c8d2071b402e300a8345e02b6c):

  • kcov/40@:
    All packages built successfully! (All logs)

  • kcov/38@:
    All packages built successfully! (All logs)

@EstebanDugueperoux2
Copy link
Contributor Author

\o/ all automatic checks are green.
Ready for manual approving.

@EstebanDugueperoux2
Copy link
Contributor Author

Thanks @uilianries for the approval.
Randomly I add another review to @madebr to unlock the merge.

@conan-center-bot conan-center-bot merged commit 85a619f into conan-io:master Jun 30, 2022
@EstebanDugueperoux2 EstebanDugueperoux2 deleted the package/kcov branch June 30, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] kcov/40
6 participants