Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drogon: add recipe #10848

Merged
merged 11 commits into from
May 28, 2022
Merged

drogon: add recipe #10848

merged 11 commits into from
May 28, 2022

Conversation

toge
Copy link
Contributor

@toge toge commented May 18, 2022

Specify library name and version: drogon/1.7.5

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 6ab1e0d
drogon/1.7.5 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdrogon.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@toge toge closed this May 22, 2022
@toge toge reopened this May 22, 2022
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit c10f4d4
drogon/1.7.5 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdrogon.so' links to system library 'm' but it is not in cpp_info.system_libs.

@github-actions github-actions bot mentioned this pull request May 23, 2022
Open
uilianries
uilianries reviewed May 23, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice recipe. Only few points to be cleared.

recipes/drogon/all/conanfile.py Show resolved Hide resolved
recipes/drogon/all/conanfile.py Outdated
def configure(self):
if self.options.shared:
del self.options.fPIC
self.options["trantor"].shared = True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.options["trantor"].shared = True
self.options["trantor"].shared = True

Any error which enforces trantor as shared?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the way of upstream CMakeLists.txt.
https://github.com/drogonframework/drogon/blob/v1.7.5/CMakeLists.txt#L54-L55

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

recipes/drogon/all/conanfile.py Outdated
self.requires("coz/cci.20210322")
if self.options.with_brotli:
self.requires("brotli/1.0.9")
if self.options.with_postgres:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to use self.options.get_safe instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I fixed those.

@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit ce771ed
drogon/1.7.5 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdrogon.so' links to system library 'm' but it is not in cpp_info.system_libs.

uilianries
uilianries approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SSE4
SSE4 reviewed May 25, 2022
View reviewed changes
recipes/drogon/all/conanfile.py
def configure(self):
if self.options.shared:
del self.options.fPIC
self.options["trantor"].shared = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be better to reject invalid shared/static combinations in validate

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem we require only static libs by default. If we only validate, this package would break for any configuration.

SSE4
SSE4 reviewed May 25, 2022
View reviewed changes
recipes/drogon/all/patches/1.7.5-0002-remove-boost-components.patch
if(NEED_BOOST_FS)
- find_package(Boost 1.49.0 COMPONENTS filesystem system REQUIRED)
+ # TODO: component specified find_package is always failed. Need to fix it.
+ find_package(Boost 1.49.0 REQUIRED)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting. might be a conan generator bug?

@SSE4 SSE4 closed this May 27, 2022
@SSE4 SSE4 reopened this May 27, 2022
@SSE4 SSE4 closed this May 27, 2022
@SSE4 SSE4 reopened this May 27, 2022
@conan-center-bot
Copy link
Collaborator

All green in build 14 (ce771ed3caa7691071be1ce4d015e69d49c337a8):

  • drogon/1.7.5@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 243c805 into conan-io:master May 28, 2022
@SpaceIm SpaceIm mentioned this pull request Nov 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@SSE4 SSE4 SSE4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@toge @conan-center-bot @SSE4 @uilianries