(#10727) Add recipe for cuda-api-wrappers/0.5.1 #10728

aborzunov · 2022-05-11T06:29:43Z

Specify library name and version: cuda-api-wrappers/0.5.1

Thin C++-flavored header-only wrappers for the CUDA APIs.

This library is header-only, but it requires cuda. So test-package just checks presence of some header that do not include cuda related headers.

closes #10727

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

uilianries · 2022-05-11T08:00:24Z

recipes/cuda-api-wrappers/all/conanfile.py

+        self.cpp_info.names["cmake_find_package"] = "cuda-api-wrappers"
+        self.cpp_info.names["cmake_find_package_multi"] = "cuda-api-wrappers"


Suggested change

self.cpp_info.names["cmake_find_package"] = "cuda-api-wrappers"

self.cpp_info.names["cmake_find_package_multi"] = "cuda-api-wrappers"

# TODO: to remove in conan v2 once cmake_find_package* generators removed

self.cpp_info.names["cmake_find_package"] = "cuda-api-wrappers"

self.cpp_info.names["cmake_find_package_multi"] = "cuda-api-wrappers"

self.cpp_info.set_property("cmake_file_name", "cuda-api-wrappers")

self.cpp_info.set_property("cmake_target_name", "cuda-api-wrapers::cuda-api-wrappers")

Better compatibility with Conan 2.0

Target name is wrong, there should be 3 imported targets cuda-api-wrapers::runtime-and-driver, cuda-api-wrapers::nvtx and cuda-api-wrapers::nvrtc:
https://github.com/eyalroz/cuda-api-wrappers/blob/b2d2c22f577be74a4070f47dacff3736d5878835/CMakeLists.txt#L39-L43
https://github.com/eyalroz/cuda-api-wrappers/blob/b2d2c22f577be74a4070f47dacff3736d5878835/CMakeLists.txt#L92-L94
https://github.com/eyalroz/cuda-api-wrappers/blob/b2d2c22f577be74a4070f47dacff3736d5878835/CMakeLists.txt#L117-L122

@SpaceIm Thank you!

I'm a bit confused, how to declare 3 imported targets?

def package_info(self): self.cpp_info.names["cmake_find_package"] = "cuda-api-wrappres" self.cpp_info.names["cmake_find_package_multi"] = "cuda-api-wrappers" self.cpp_info.components["runtime-and-driver"].names["cmake_find_package"] = "runtime-and-driver" self.cpp_info.components["runtime-and-driver"].system_libs = ["libcudart", "libcuda"] self.cpp_info.components["nvrtc"].names["cmake_find_package"] = "nvrtc" self.cpp_info.components["nvrtc"].system_libs = ["libnvrtc", "libcudart", "libcuda"] self.cpp_info.components["nvtx"].names["cmake_find_package"] = "nvtx" self.cpp_info.components["nvtx"].requires = ["runtime-and-driver"] self.cpp_info.components["nvtx"].system_libs = ["libnvToolsExt", "libthreads", "libcudart", "libcuda"]

Can you provide any example?

Yes, with Conan the only way to provide several targets is to create several components

uilianries · 2022-05-11T08:03:26Z

recipes/cuda-api-wrappers/all/test_package/test_package.cpp

+
+
+int main() {
+


Try consuming something from header. You could generate a version, for instance: https://github.com/eyalroz/cuda-api-wrappers/blob/master/src/cuda/api/versions.hpp#L115

That's not possible, there is a dependency to CUDA. This recipe shouldn't be merged until we have some cuda recipe, even a placeholder. #4844

If this recipe requires cuda it should declare it as requirement, even if this is a header-only package. Of course, we need first that recipe (placeholder, mock,...)

recipes/cuda-api-wrappers/all/conanfile.py

jgsogo · 2022-06-28T07:58:48Z

recipes/cuda-api-wrappers/all/conanfile.py

@@ -0,0 +1,34 @@
+from conans import ConanFile, tools
+from conans.errors import ConanInvalidConfiguration


Suggested change

from conans.errors import ConanInvalidConfiguration

Checks from the linter will be mandatory in the near future, so better to start fixing them. Thanks!

jgsogo · 2022-06-28T08:01:44Z

recipes/cuda-api-wrappers/all/test_package/test_package.cpp

+
+
+int main() {
+


If this recipe requires cuda it should declare it as requirement, even if this is a header-only package. Of course, we need first that recipe (placeholder, mock,...)

jgsogo · 2022-06-28T08:02:16Z

recipes/cuda-api-wrappers/all/conanfile.py

+        self.cpp_info.names["cmake_find_package"] = "cuda-api-wrappers"
+        self.cpp_info.names["cmake_find_package_multi"] = "cuda-api-wrappers"


Yes, with Conan the only way to provide several targets is to create several components

conan-center-bot · 2022-07-02T01:42:02Z

All green in build 7 (005b2cb17dc4f32219f1b55a47f3288b59060cdf):

cuda-api-wrappers/0.5.1@:
All packages built successfully! (All logs)

Result of export using Conan v2 (informative)

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this export step will work.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-10728/recipes/cuda-api-wrappers/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-10728/recipes/cuda-api-wrappers/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-10728/recipes/cuda-api-wrappers/all/conanfile.py", line 1, in <module>
    from conans import ConanFile, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

stale · 2022-08-01T02:08:48Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2022-09-08T21:23:41Z

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

This comment has been minimized.

Sign in to view

prince-chrismc mentioned this pull request May 11, 2022

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

uilianries reviewed May 11, 2022

View reviewed changes

SpaceIm reviewed May 11, 2022

View reviewed changes

recipes/cuda-api-wrappers/all/conanfile.py Outdated Show resolved Hide resolved

SSE4 closed this May 27, 2022

SSE4 reopened this May 27, 2022

SSE4 closed this May 27, 2022

SSE4 reopened this May 27, 2022

This comment has been minimized.

Sign in to view

(conan-io#10727) Add recipe for cuda-api-wrappers/0.5.1

005b2cb

aborzunov force-pushed the recipe/cuda-api-wrappers-#10727 branch from fd0b901 to 005b2cb Compare May 30, 2022 12:01

This comment has been minimized.

Sign in to view

conan-center-bot requested review from uilianries and SSE4 May 31, 2022 12:03

conan-center-bot requested a review from danimtb June 15, 2022 12:01

conan-center-bot requested a review from jgsogo June 24, 2022 12:01

jgsogo reviewed Jun 28, 2022

View reviewed changes

jgsogo mentioned this pull request Jun 30, 2022

CUDA - Waiting for a meaningful proposal #11448

Open

2 tasks

stale bot added the stale label Aug 1, 2022

stale bot closed this Sep 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(#10727) Add recipe for cuda-api-wrappers/0.5.1 #10728

(#10727) Add recipe for cuda-api-wrappers/0.5.1 #10728

aborzunov commented May 11, 2022

This comment has been minimized.

uilianries May 11, 2022

SpaceIm May 11, 2022 •

edited

Loading

uilianries May 30, 2022

aborzunov May 30, 2022 •

edited

Loading

jgsogo Jun 28, 2022

uilianries May 11, 2022

SpaceIm May 11, 2022 •

edited

Loading

jgsogo Jun 28, 2022

This comment has been minimized.

This comment has been minimized.

jgsogo Jun 28, 2022

jgsogo Jun 28, 2022

jgsogo Jun 28, 2022

conan-center-bot commented Jul 2, 2022

stale bot commented Aug 1, 2022

stale bot commented Sep 8, 2022

		self.cpp_info.names["cmake_find_package"] = "cuda-api-wrappers"
		self.cpp_info.names["cmake_find_package_multi"] = "cuda-api-wrappers"

		@@ -0,0 +1,34 @@
		from conans import ConanFile, tools
		from conans.errors import ConanInvalidConfiguration



		int main() {



		int main() {

(#10727) Add recipe for cuda-api-wrappers/0.5.1 #10728

(#10727) Add recipe for cuda-api-wrappers/0.5.1 #10728

Conversation

aborzunov commented May 11, 2022

This comment has been minimized.

Choose a reason for hiding this comment

SpaceIm May 11, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aborzunov May 30, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SpaceIm May 11, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conan-center-bot commented Jul 2, 2022

stale bot commented Aug 1, 2022

stale bot commented Sep 8, 2022

SpaceIm May 11, 2022 •

edited

Loading

aborzunov May 30, 2022 •

edited

Loading

SpaceIm May 11, 2022 •

edited

Loading