Support fingerprinting directories #11
Conversation
| return abs(time.time() - self.last_modified * 1e-9) < min_dtime | ||
|
|
||
| def to_tuple(self): | ||
| return sum(sorted(self.tree_fprints.items()), ()) |
There was a problem hiding this comment.
sorted could likely be the "killer" of performance, while also would make us feel nice when we gain significant boost when we stop doing that ;)
would be important to provide some initial benchmarking setup, filed #12 with idea(s)
There was a problem hiding this comment.
Without sorted, the fingerprints passed to the memoized function would be unstable, and caching wouldn't work reliably.
There was a problem hiding this comment.
I understand the purpose of it, but I wonder if/how it could be avoided. E.g. if "unstable" due to changes to the directory content -- until we introduce some include/exclude support, we should be fine even without it, which would help to lower the "expected caching overhead" and establish a new baseline to go from. If it is "unstable" because it is non-deterministic (but then why? without changes to file system I do not see why it would be happening), then indeed sorting of some kind is necessary unless we workaround somehow, and we should look into optimizing that somehow accounting on the fact that we might just need to discover that something changed instead of knowing the ultimate order.
again, worth looking in more detail on how git does it...
|
Great! yet to try, but looks good and green. left a note on |
Initial implementation for #4.